Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2670)

Unified Diff: chrome/android/BUILD.gn

Issue 1691993003: Hook up LeakCanary to ChromePublic.apk (behind a GN arg) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@leak-canary-2
Patch Set: better proguarding Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/chrome_public_apk_tmpl.gni » ('j') | chrome/android/java/AndroidManifest.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/BUILD.gn
diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn
index dab510c9e7ac1bd212dc7d9e2ae199da39674bc6..c059bd272915cac331538a11df7bc2f6092bc1b8 100644
--- a/chrome/android/BUILD.gn
+++ b/chrome/android/BUILD.gn
@@ -14,23 +14,13 @@ import("//third_party/protobuf/proto_library.gni")
import("channel.gni")
manifest_package = "org.chromium.chrome"
-if (enable_configuration_policy) {
- configuration_policy = 1
-} else {
- configuration_policy = 0
-}
-chrome_public_jinja_variables = [
- "channel=$android_channel",
- "manifest_package=$manifest_package",
- "configuration_policy=$configuration_policy",
-]
+chrome_public_jinja_variables = default_chrome_public_jinja_variables +
+ [ "manifest_package=$manifest_package" ]
-chrome_sync_shell_jinja_variables = [
- "channel=$android_channel",
- "manifest_package=org.chromium.chrome.sync_shell",
- "configuration_policy=$configuration_policy",
-]
+chrome_sync_shell_jinja_variables =
+ default_chrome_public_jinja_variables +
+ [ "manifest_package=org.chromium.chrome.sync_shell" ]
chrome_apk_gypi = exec_script("//build/gypi_to_gn.py",
[ rebase_path("chrome_apk.gyp") ],
@@ -155,6 +145,7 @@ android_library("chrome_java") {
"//third_party/cacheinvalidation:cacheinvalidation_proto_java",
"//third_party/gif_player:gif_player_java",
"//third_party/jsr-305:jsr_305_javalib",
+ "//third_party/leakcanary:leakcanary_java",
"//ui/android:ui_java",
"//ui/android:ui_java_resources",
google_play_services_library,
« no previous file with comments | « no previous file | chrome/android/chrome_public_apk_tmpl.gni » ('j') | chrome/android/java/AndroidManifest.xml » ('J')

Powered by Google App Engine
This is Rietveld 408576698