Issue 1691943002: Don't use Set when collecting constant targets in a unit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1691943002: Don't use Set when collecting constant targets in a unit. (Closed)

Created:
4 years, 10 months ago by scheglov

Modified:
4 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Don't use Set when collecting constant targets in a unit. This forces location / hashCode computation and caching, and the unit is not linked to its library, so the cached values are not valid. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c4602b0c8b5b62a183194ce72c140a98b9666825

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	pkg/analyzer/lib/src/generated/constant.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	pkg/analyzer/test/generated/constant_test.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

4 years, 10 months ago (2016-02-11 20:35:39 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c4602b0c8b5b62a183194ce72c140a98b9666825 (presubmit successful).