Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1691923002: Make summary format stable when adding getters to idl. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make summary format stable when adding getters to idl. This mechanism is the same as the "id" mechanism described in http://google.github.io/flatbuffers/flatbuffers_guide_writing_schema.html, except that for us the ids are always mandatory. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/5a58e0963998a79ff02f0727dee955761a2d6570

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+494 lines, -279 lines) Patch
M pkg/analyzer/lib/src/summary/base.dart View 1 chunk +15 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.dart View 57 chunks +268 lines, -268 lines 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 78 chunks +158 lines, -0 lines 1 comment Download
M pkg/analyzer/tool/summary/generate.dart View 10 chunks +47 lines, -10 lines 0 comments Download
M pkg/analyzer/tool/summary/idl_model.dart View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
https://codereview.chromium.org/1691923002/diff/1/pkg/analyzer/lib/src/summary/idl.dart File pkg/analyzer/lib/src/summary/idl.dart (right): https://codereview.chromium.org/1691923002/diff/1/pkg/analyzer/lib/src/summary/idl.dart#newcode88 pkg/analyzer/lib/src/summary/idl.dart:88: @Id(4) Note: I used smaller ids for the most ...
4 years, 10 months ago (2016-02-11 19:10:27 UTC) #2
scheglov
LGTM
4 years, 10 months ago (2016-02-11 19:18:31 UTC) #3
Paul Berry
4 years, 10 months ago (2016-02-11 22:38:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5a58e0963998a79ff02f0727dee955761a2d6570 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698