third_party/WebKit/Source/core/svg/SVGSVGElement.cpp - Issue 1691883003: Deprecate SVGZoomEvent and SVGZoomEvents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

Issue 1691883003: Deprecate SVGZoomEvent and SVGZoomEvents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Time to update histograms.xml Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/build/scripts/templates/EventFactory.cpp.tmpl ('K') | « third_party/WebKit/Source/core/frame/UseCounter.cpp ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp b/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

index fc3a9d3eb6083fd04562253ea4a45421fa888ca0..44f1590b4fc52be15f1a49b845920bcfdda514ed 100644

--- a/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGSVGElement.cpp

@@ -201,16 +201,18 @@ void SVGSVGElement::parseAttribute(const QualifiedName& name, const AtomicString

bool setListener = true;

// Only handle events if we're the outermost <svg> element

- if (name == HTMLNames::onunloadAttr)

+ if (name == HTMLNames::onunloadAttr) {

document().setWindowAttributeEventListener(EventTypeNames::unload, createAttributeEventListener(document().frame(), name, value, eventParameterName()));

- else if (name == HTMLNames::onresizeAttr)

+ } else if (name == HTMLNames::onresizeAttr) {

document().setWindowAttributeEventListener(EventTypeNames::resize, createAttributeEventListener(document().frame(), name, value, eventParameterName()));

- else if (name == HTMLNames::onscrollAttr)

+ } else if (name == HTMLNames::onscrollAttr) {

document().setWindowAttributeEventListener(EventTypeNames::scroll, createAttributeEventListener(document().frame(), name, value, eventParameterName()));

- else if (name == SVGNames::onzoomAttr)

+ } else if (name == SVGNames::onzoomAttr) {

+ UseCounter::countDeprecation(document(), UseCounter::DeprecateSVGZoomEvent);

document().setWindowAttributeEventListener(EventTypeNames::zoom, createAttributeEventListener(document().frame(), name, value, eventParameterName()));

- else

+ } else {

setListener = false;

+ }

if (setListener)

return;