Deprecate SVGZoomEvent and SVGZoomEvents

Deprecate SVGZoomEvent and SVGZoomEvents

Deprecate the SVGZoomEvent interface and the corresponding onzoom
attribute. Show deprecation message to the user when creating the
event or when setting up an event handler using onzoom="..." on
<svg:svg>.

Intent to deprecate:

https://groups.google.com/a/chromium.org/d/msg/blink-dev/5PEUh2qHa7c/IUGlM4a9CQAJ

BUG=367890
Committed: https://crrev.com/3593524a1ffcca4b91dacd355b6fc3145ffa223d
Cr-Commit-Position: refs/heads/master@{#375771}

[davve, 2016-02-12 15:04:55]

davve@opera.com changed reviewers:
+ philipj@opera.com

[philipj_slow, 2016-02-13 14:48:00]

LGTM

Did you take a look at the diff of the generated code, to double check the
template changes? I guess the only change is one added countDeprecation()?

https://codereview.chromium.org/1691883003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/build/scripts/make_event_factory.py (right):

https://codereview.chromium.org/1691883003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/make_event_factory.py:58: # See
https://dom.spec.whatwg.org/#dom-document-createevent
The ":" and the "See" kind of serve the same purpose.

https://codereview.chromium.org/1691883003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/make_event_factory.py:71: def
create_event_deprecate_list(name):
Yeah, with some luck we can make this a very big list in a few months, and then
make it all go away again a few months still later :)

https://codereview.chromium.org/1691883003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/build/scripts/templates/EventFactory.cpp.tmpl
(right):

https://codereview.chromium.org/1691883003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/templates/EventFactory.cpp.tmpl:27: {%
if event|script_name|create_event_deprecate_list %}
Could this be written in an {% else %} branch with a somewhat simplified
condition to make it entirely obvious that nothing can be both counted and
deprecated? Something like

{% if not on whitelist % }
{% if deprecated %}
::countDeprecation()
{% else %}
::count()
{% endif %}
{% endif %}

?

[davve, 2016-02-16 08:16:35]

Two, there is the alias too. Diff in generated file (with upcoming ps#3):

drogon:gen/blink/core [master] % git diff
diff --git a/Event.cpp b/Event.cpp
index dcad25a..f70eb3a 100644
--- a/Event.cpp
+++ b/Event.cpp
@@ -5,7 +5,7 @@
 #include "core/events/EventFactory.h"

 #include "EventHeaders.h"
-#include "core/frame/UseCounter.h"
+#include "core/frame/Deprecation.h"
 #include "platform/RuntimeEnabledFeatures.h"

 namespace blink {
@@ -142,6 +142,7 @@ PassRefPtrWillBeRawPtr<Event>
EventFactory::create(ExecutionContext* executionCo
         return TrackEvent::create();
     }
     if (type == "SVGZoomEvent") {
+        Deprecation::countDeprecation(executionContext,
UseCounter::DeprecateSVGZoomEvent);
         return SVGZoomEvent::create();
     }
     if (type == "WebKitAnimationEvent") {
@@ -174,6 +175,7 @@ PassRefPtrWillBeRawPtr<Event>
EventFactory::create(ExecutionContext* executionCo
         return Event::create();
     }
     if (type == "SVGZoomEvents") {
+        Deprecation::countDeprecation(executionContext,
UseCounter::DeprecateSVGZoomEvent);
         return SVGZoomEvent::create();
     }
     if (equalIgnoringCase(type, "UIEvents")) {

https://codereview.chromium.org/1691883003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/build/scripts/make_event_factory.py (right):

https://codereview.chromium.org/1691883003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/make_event_factory.py:58: # See
https://dom.spec.whatwg.org/#dom-document-createevent
On 2016/02/13 14:48:00, philipj_UTC7 wrote:
> The ":" and the "See" kind of serve the same purpose.

Done.

https://codereview.chromium.org/1691883003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/build/scripts/templates/EventFactory.cpp.tmpl
(right):

https://codereview.chromium.org/1691883003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/templates/EventFactory.cpp.tmpl:27: {%
if event|script_name|create_event_deprecate_list %}
On 2016/02/13 14:48:00, philipj_UTC7 wrote:
> Could this be written in an {% else %} branch with a somewhat simplified
> condition to make it entirely obvious that nothing can be both counted and
> deprecated? Something like
> 
> {% if not on whitelist % }
> {% if deprecated %}
> ::countDeprecation()
> {% else %}
> ::count()
> {% endif %}
> {% endif %}
> 
> ?

Good idea, I like that.

[philipj_slow, 2016-02-16 09:49:35]

LGTM, diff makes sense.

https://codereview.chromium.org/1691883003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/UseCounter.h (right):

https://codereview.chromium.org/1691883003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/UseCounter.h:1086: DeprecateSVGZoomEvent =
1232,
Maybe just SVGZoomEvent? We have many deprecated things without "Deprecate" in
the name and unfortunately some of the inverse (DeprecatedWebKitGradient) so I
like to treat it as an orthogonal concern.

[davve, 2016-02-16 10:09:37]

davve@opera.com changed reviewers:
+ isherman@chromium.org

[davve, 2016-02-16 10:09:37]

+isherman for histograms.xml.

https://codereview.chromium.org/1691883003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/UseCounter.h (right):

https://codereview.chromium.org/1691883003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/UseCounter.h:1086: DeprecateSVGZoomEvent =
1232,
On 2016/02/16 09:49:35, philipj_UTC7 wrote:
> Maybe just SVGZoomEvent? We have many deprecated things without "Deprecate" in
> the name and unfortunately some of the inverse (DeprecatedWebKitGradient) so I
> like to treat it as an orthogonal concern.

Done.

[davve, 2016-02-16 10:13:36]

The CQ bit was checked by davve@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-16 10:14:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1691883003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1691883003/60001

[commit-bot: I haz the power, 2016-02-16 11:48:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-16 11:48:26]

Dry run: This issue passed the CQ dry run.

[Ilya Sherman, 2016-02-16 20:29:30]

histograms.xml lgtm

[philipj_slow, 2016-02-17 02:48:17]

The CQ bit was checked by philipj@opera.com

[philipj_slow, 2016-02-17 02:48:17]

The patchset sent to the CQ was uploaded after l-g-t-m from philipj@opera.com
Link to the patchset: https://codereview.chromium.org/1691883003/#ps60001
(title: "Update -expected files with deprecation messages and rename counter to
SVGZoomEvent")

[commit-bot: I haz the power, 2016-02-17 02:49:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1691883003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1691883003/60001

[commit-bot: I haz the power, 2016-02-17 02:56:42]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-02-17 02:57:59]

Description was changed from

==========
Deprecate SVGZoomEvent and SVGZoomEvents

Deprecate the SVGZoomEvent interface and the corresponding onzoom
attribute. Show deprecation message to the user when creating the
event or when setting up an event handler using onzoom="..." on
<svg:svg>.

Intent to deprecate:

https://groups.google.com/a/chromium.org/d/msg/blink-dev/5PEUh2qHa7c/IUGlM4a9...

BUG=367890
==========

to

==========
Deprecate SVGZoomEvent and SVGZoomEvents

Deprecate the SVGZoomEvent interface and the corresponding onzoom
attribute. Show deprecation message to the user when creating the
event or when setting up an event handler using onzoom="..." on
<svg:svg>.

Intent to deprecate:

https://groups.google.com/a/chromium.org/d/msg/blink-dev/5PEUh2qHa7c/IUGlM4a9...

BUG=367890

Committed: https://crrev.com/3593524a1ffcca4b91dacd355b6fc3145ffa223d
Cr-Commit-Position: refs/heads/master@{#375771}
==========

[commit-bot: I haz the power, 2016-02-17 02:58:00]

Patchset 4 (id:??) landed as
https://crrev.com/3593524a1ffcca4b91dacd355b6fc3145ffa223d
Cr-Commit-Position: refs/heads/master@{#375771}