Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1691823002: Test SkAndroidCodec for more types (Closed)

Created:
4 years, 10 months ago by scroggo
Modified:
4 years, 10 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Test SkAndroidCodec for more types Now that SkAndroidCodec supports all types, stop selectively running its tests for the types supported by BRD. For the tests that actually require BRD support (i.e. partial scanlines), change the method name from supports_scaled_codec to supports_partial_scanlines to be more accurate today. Use the name SkAndroidCodec instead of SkScaledCodec. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1691823002 Committed: https://skia.googlesource.com/skia/+/bed1ed6eaced308149a05fecded14d8458c7d99c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M tests/CodexTest.cpp View 5 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
scroggo
4 years, 10 months ago (2016-02-11 16:08:28 UTC) #3
msarett
lgtm
4 years, 10 months ago (2016-02-11 16:11:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691823002/1
4 years, 10 months ago (2016-02-11 17:56:21 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 18:24:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bed1ed6eaced308149a05fecded14d8458c7d99c

Powered by Google App Engine
This is Rietveld 408576698