Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: chrome/browser/devtools/chrome_devtools_discovery_provider.cc

Issue 1691813003: Add --auto-open-devtools-for-tabs flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/chrome_devtools_discovery_provider.cc
diff --git a/chrome/browser/devtools/chrome_devtools_discovery_provider.cc b/chrome/browser/devtools/chrome_devtools_discovery_provider.cc
index 761c2b4c20e97f35f43dfa4a424314b51dab163e..c3626e92645f936c95ee757d0f564224f3e1d4f4 100644
--- a/chrome/browser/devtools/chrome_devtools_discovery_provider.cc
+++ b/chrome/browser/devtools/chrome_devtools_discovery_provider.cc
@@ -4,10 +4,13 @@
#include "chrome/browser/devtools/chrome_devtools_discovery_provider.h"
+#include "base/command_line.h"
#include "chrome/browser/devtools/devtools_target_impl.h"
+#include "chrome/browser/devtools/devtools_window.h"
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/browser/ui/browser_navigator.h"
#include "chrome/browser/ui/browser_navigator_params.h"
+#include "chrome/common/chrome_switches.h"
namespace {
@@ -24,12 +27,25 @@ CreateNewChromeTab(const GURL& url) {
} // namespace
-ChromeDevToolsDiscoveryProvider::ChromeDevToolsDiscoveryProvider() {
+ChromeDevToolsDiscoveryProvider::ChromeDevToolsDiscoveryProvider()
+ : browser_tab_strip_tracker_(this, nullptr, nullptr) {
+ if (base::CommandLine::ForCurrentProcess()->HasSwitch(
pfeldman 2016/02/12 02:15:08 How does this make sense here?
+ switches::kAutoOpenDevToolsForTabs)) {
+ browser_tab_strip_tracker_.Init(
+ BrowserTabStripTracker::InitWith::ALL_BROWERS);
+ }
}
ChromeDevToolsDiscoveryProvider::~ChromeDevToolsDiscoveryProvider() {
}
+void ChromeDevToolsDiscoveryProvider::TabInsertedAt(
+ content::WebContents* contents,
+ int index,
+ bool foreground) {
+ DevToolsWindow::OpenDevToolsWindow(contents);
+}
+
devtools_discovery::DevToolsTargetDescriptor::List
ChromeDevToolsDiscoveryProvider::GetDescriptors() {
std::vector<DevToolsTargetImpl*> list = DevToolsTargetImpl::EnumerateAll();

Powered by Google App Engine
This is Rietveld 408576698