Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 1691773002: wire up new json code in skiaserve (Closed)

Created:
4 years, 10 months ago by joshua.litt
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fixup comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M tools/debugger/SkDebugCanvas.h View 1 1 chunk +4 lines, -3 lines 0 comments Download
M tools/debugger/SkDebugCanvas.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/skiaserve/skiaserve.cpp View 2 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
joshualitt
ptal, skiaserve still depends on SkJSONCanvas for some static methods.
4 years, 10 months ago (2016-02-11 13:57:44 UTC) #3
ethannicholas
On 2016/02/11 13:57:44, joshualitt wrote: > ptal, skiaserve still depends on SkJSONCanvas for some static ...
4 years, 10 months ago (2016-02-11 14:23:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691773002/20001
4 years, 10 months ago (2016-02-11 14:31:49 UTC) #7
commit-bot: I haz the power
Failed to commit the patch.
4 years, 10 months ago (2016-02-11 15:03:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691773002/20001
4 years, 10 months ago (2016-02-11 15:04:19 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 15:10:25 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/db6a254bdcf6884db172f716966d7787e0d6f264

Powered by Google App Engine
This is Rietveld 408576698