Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 169173009: Revert of Apply patch for bot_update (Closed)

Created:
6 years, 10 months ago by Ryan Tseng
Modified:
6 years, 9 months ago
Reviewers:
cmp, agable, hinoka
CC:
chromium-reviews, stip+watch_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, kjellander+cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Visibility:
Public.

Description

Revert of Apply patch for bot_update (https://codereview.chromium.org/170843003/) Reason for revert: Arg changes breaks existing bots. Original issue's description: > Apply patch for bot_update > > Does the following: > 1. Download patch > 2. Strip off the a/ prefixes in the patch, if existant > 3. git apply --index -p0 --3way < [patch data] > > BUG=339171 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=252469 TBR=agable@chromium.org,hinoka@chromium.org NOTREECHECKS=true NOTRY=true BUG=339171

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -157 lines) Patch
M scripts/master/factory/commands.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/master/factory/gclient_factory.py View 1 chunk +1 line, -2 lines 0 comments Download
M scripts/slave/bot_update.py View 11 chunks +18 lines, -154 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ryan Tseng
Created Revert of Apply patch for bot_update
6 years, 10 months ago (2014-02-21 02:49:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@google.com/169173009/1
6 years, 10 months ago (2014-02-21 02:49:42 UTC) #2
cmp
lgtm
6 years, 10 months ago (2014-02-21 02:49:58 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 02:50:53 UTC) #4
commit-bot: I haz the power
Presubmit check for 169173009-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 10 months ago (2014-02-21 02:50:54 UTC) #5
agable
6 years, 9 months ago (2014-02-28 18:22:54 UTC) #6
Close this issue?

Powered by Google App Engine
This is Rietveld 408576698