Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 169173007: CrOs first-run UI polished. (Closed)

Created:
6 years, 10 months ago by dzhioev (left Google)
Modified:
6 years, 10 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

CrOs first-run UI polished. * Added shadows for bubbles. * Make app window to set its size automatically. * Prevented buttons blinking on hover/click/focus. BUG=342397 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251767

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -25 lines) Patch
M chrome/browser/resources/chromeos/first_run/app/background.js View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/first_run/app/greeting_image_enabled.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/first_run/app/main.html View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/first_run/app/main.js View 1 chunk +9 lines, -6 lines 1 comment Download
M chrome/browser/resources/chromeos/first_run/app/style.css View 3 chunks +8 lines, -12 lines 0 comments Download
M chrome/browser/resources/chromeos/first_run/first_run.html View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/first_run/preload.css View 1 chunk +53 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/first_run/step_bubble.css View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dzhioev (left Google)
6 years, 10 months ago (2014-02-17 22:30:30 UTC) #1
Nikita (slow)
lgtm https://codereview.chromium.org/169173007/diff/1/chrome/browser/resources/chromeos/first_run/app/main.js File chrome/browser/resources/chromeos/first_run/app/main.js (right): https://codereview.chromium.org/169173007/diff/1/chrome/browser/resources/chromeos/first_run/app/main.js#newcode14 chrome/browser/resources/chromeos/first_run/app/main.js:14: bounds.left = Math.round(0.5 * (window.screen.availWidth - bounds.width)); nit: ...
6 years, 10 months ago (2014-02-18 10:36:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/169173007/1
6 years, 10 months ago (2014-02-18 10:36:29 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 12:07:53 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=265504
6 years, 10 months ago (2014-02-18 12:07:54 UTC) #5
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 10 months ago (2014-02-18 12:26:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dzhioev@chromium.org/169173007/1
6 years, 10 months ago (2014-02-18 12:26:48 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 16:23:25 UTC) #8
Message was sent while issue was closed. 
Change committed as 251767

Powered by Google App Engine
This is Rietveld 408576698