Update incomplete credentials in Login Database

Update incomplete credentials in Login Database

Incomplete credentials (missing username_element, password_element
or submit_element) that might get added to the database via importing
from other browsers should now be updated correctly when they're
entered into the right form.

BUG=344337
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253791

[Garrett Casto, 2014-02-18 19:01:09]

Unfortunately LoginDatabase isn't the only way that these PasswordForms are
serialized. On Linux we use GNOME or KWallet if they are available. It looks
like you need to update CompareForms() in native_backend_kwallet_x and both
UpdateLoginSearch() and UpdateLogin() in native_backend_gnome_x.

[mpawlowski, 2014-02-20 08:54:56]

On 2014/02/18 19:01:09, Garrett Casto wrote:
> Unfortunately LoginDatabase isn't the only way that these PasswordForms are
> serialized. On Linux we use GNOME or KWallet if they are available. It looks
> like you need to update CompareForms() in native_backend_kwallet_x and both
> UpdateLoginSearch() and UpdateLogin() in native_backend_gnome_x.

That is correct, I'll try fixing those and adding some UTs. This may take a
while though, I need to find some time to setup a Linux dev env.

[mpawlowski, 2014-02-25 13:09:57]

I started work on the Linux part and I realized that this probably won't be a
problem on this platform - on Linux we only import stuff from Firefox. We have
all meta-data in this case, there shouldn't be an issue with incomplete imported
credentials.

[Garrett Casto, 2014-02-26 21:35:56]

LGTM.

Didn't realize we could get this information from FF.

[mpawlowski, 2014-02-27 08:28:45]

The CQ bit was checked by mpawlowski@opera.com

[commit-bot: I haz the power, 2014-02-27 08:28:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mpawlowski@opera.com/169173005/110001

[commit-bot: I haz the power, 2014-02-27 13:55:08]

Change committed as 253791