Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issue 1691723004: Only allow |0 and *1.0 for asm validator foreign variables. (Closed)

Created:
4 years, 10 months ago by bradnelson
Modified:
4 years, 10 months ago
Reviewers:
titzer, aseemgarg, bradn
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Only allow |0 and *1.0 for asm validator foreign variables. Require that foreign variable imports have a correct type annotation, _including_ checking the value of the multiplier is 0 or 1.0 as appropriate. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=test-asm-validator R=aseemgarg@chromium.org,titzer@chromium.org LOG=N Committed: https://crrev.com/413c266817f49419765ede4049bfc6ba2f3994e5 Cr-Commit-Position: refs/heads/master@{#33923}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -0 lines) Patch
M src/typing-asm.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M test/cctest/test-asm-validator.cc View 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
bradn
4 years, 10 months ago (2016-02-12 00:38:41 UTC) #2
aseemgarg
lgtm We should also try to get +X be a new kind of node instead ...
4 years, 10 months ago (2016-02-12 01:18:21 UTC) #3
bradn
Agreed, on my list :-)
4 years, 10 months ago (2016-02-12 01:28:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691723004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691723004/1
4 years, 10 months ago (2016-02-12 01:29:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 01:50:27 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-12 01:50:51 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/413c266817f49419765ede4049bfc6ba2f3994e5
Cr-Commit-Position: refs/heads/master@{#33923}

Powered by Google App Engine
This is Rietveld 408576698