Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: webkit/renderer/media/crypto/key_systems_info.cc

Issue 16917014: Revert "Allow suppressed EME canPlayType() responses to be overridden with a flag." (r208096). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/renderer/media/crypto/key_systems_info.cc
diff --git a/webkit/renderer/media/crypto/key_systems_info.cc b/webkit/renderer/media/crypto/key_systems_info.cc
index ae322e4bc6d2ad4de989ce6030f8489bf32d8a76..9810c349eaa4baa9b47d72cee3ade5e82935b880 100644
--- a/webkit/renderer/media/crypto/key_systems_info.cc
+++ b/webkit/renderer/media/crypto/key_systems_info.cc
@@ -6,8 +6,6 @@
#include "widevine_cdm_version.h" // In SHARED_INTERMEDIATE_DIR.
-// The following must be after widevine_cdm_version.h.
-
#if defined(WIDEVINE_CDM_AVAILABLE) && \
defined(OS_LINUX) && !defined(OS_CHROMEOS)
#include <gnu/libc-version.h>
@@ -15,11 +13,6 @@
#include "base/version.h"
#endif
-#if defined(DISABLE_WIDEVINE_CDM_CANPLAYTYPE)
-#include "base/command_line.h"
-#include "media/base/media_switches.h"
-#endif
-
namespace webkit_media {
static const char kClearKeyKeySystem[] = "webkit-org.w3.clearkey";
@@ -30,6 +23,7 @@ static const char kExternalClearKeyKeySystem[] =
#if defined(WIDEVINE_CDM_AVAILABLE)
// TODO(ddorwin): Automatically support parent systems: http://crbug.com/164303.
static const char kWidevineBaseKeySystem[] = "com.widevine";
+#endif // defined(WIDEVINE_CDM_AVAILABLE)
#if defined(WIDEVINE_CDM_CENC_SUPPORT_AVAILABLE)
// The supported codecs depend on what the CDM provides.
@@ -51,12 +45,6 @@ static const char kWidevineAudioMp4Codecs[] =
#endif
#endif // defined(WIDEVINE_CDM_CENC_SUPPORT_AVAILABLE)
-static inline bool IsWidevine(const std::string& key_system) {
- return key_system == kWidevineKeySystem ||
- key_system == kWidevineBaseKeySystem;
-}
-#endif // defined(WIDEVINE_CDM_AVAILABLE)
-
const MediaFormatAndKeySystem kSupportedFormatKeySystemCombinations[] = {
// Clear Key.
{ "video/webm", "vorbis,vp8,vp8.0", kClearKeyKeySystem },
@@ -76,6 +64,10 @@ const MediaFormatAndKeySystem kSupportedFormatKeySystemCombinations[] = {
#if defined(WIDEVINE_CDM_AVAILABLE)
// Widevine.
+ // See http://crbug.com/237627.
+#if defined(DISABLE_WIDEVINE_CDM_CANPLAYTYPE)
+ { "", "", kWidevineKeySystem },
+#else
{ "video/webm", "vorbis,vp8,vp8.0", kWidevineKeySystem },
{ "audio/webm", "vorbis", kWidevineKeySystem },
{ "video/webm", "vorbis,vp8,vp8.0", kWidevineBaseKeySystem },
@@ -88,6 +80,7 @@ const MediaFormatAndKeySystem kSupportedFormatKeySystemCombinations[] = {
{ "audio/mp4", kWidevineAudioMp4Codecs, kWidevineBaseKeySystem },
#endif // defined(WIDEVINE_CDM_CENC_SUPPORT_AVAILABLE)
#endif // defined(GOOGLE_CHROME_BUILD) || defined(USE_PROPRIETARY_CODECS)
+#endif // defined(DISABLE_WIDEVINE_CDM_CANPLAYTYPE)
#endif // WIDEVINE_CDM_AVAILABLE
};
@@ -124,7 +117,8 @@ const int kNumKeySystemToUUIDMapping =
bool IsSystemCompatible(const std::string& key_system) {
#if defined(WIDEVINE_CDM_AVAILABLE) && \
defined(OS_LINUX) && !defined(OS_CHROMEOS)
- if (IsWidevine(key_system)) {
+ if (key_system == kWidevineKeySystem ||
+ key_system == kWidevineBaseKeySystem) {
Version glibc_version(gnu_get_libc_version());
DCHECK(glibc_version.IsValid());
return !glibc_version.IsOlderThan(WIDEVINE_CDM_MIN_GLIBC_VERSION);
@@ -133,17 +127,6 @@ bool IsSystemCompatible(const std::string& key_system) {
return true;
}
-bool IsCanPlayTypeSuppressed(const std::string& key_system) {
-#if defined(DISABLE_WIDEVINE_CDM_CANPLAYTYPE)
- // See http://crbug.com/237627.
- if (IsWidevine(key_system) &&
- !CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEncryptedMediaCanPlayTypeOverride))
- return true;
-#endif
- return false;
-}
-
std::string KeySystemNameForUMAGeneric(const std::string& key_system) {
if (key_system == kClearKeyKeySystem)
return "ClearKey";
« no previous file with comments | « webkit/renderer/media/crypto/key_systems_info.h ('k') | webkit/renderer/media/crypto/key_systems_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698