base/strings/sys_string_conversions_mac.mm - Issue 16917011: mac: Replace base::mac::ScopedCFTypeRef with base::ScopedCFTypeRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/strings/sys_string_conversions_mac.mm

Issue 16917011: mac: Replace base::mac::ScopedCFTypeRef with base::ScopedCFTypeRef. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: with fixed off-by-1 in git-clang-format Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/strings/sys_string_conversions_mac.mm

diff --git a/base/strings/sys_string_conversions_mac.mm b/base/strings/sys_string_conversions_mac.mm

index 3650e4efb92a1772d882d5cdb4fcd474a4d3a152..9479e787c0e047c4edfdfb2964f51e53282854fc 100644

--- a/base/strings/sys_string_conversions_mac.mm

+++ b/base/strings/sys_string_conversions_mac.mm

@@ -78,14 +78,13 @@ static OutStringType STLStringToSTLStringWithEncodingsT(

if (in_length == 0)

return OutStringType();

- base::mac::ScopedCFTypeRef<CFStringRef> cfstring(

- CFStringCreateWithBytesNoCopy(NULL,

- reinterpret_cast<const UInt8*>(in.data()),

- in_length *

- sizeof(typename InStringType::value_type),

- in_encoding,

- false,

- kCFAllocatorNull));

+ base::ScopedCFTypeRef<CFStringRef> cfstring(CFStringCreateWithBytesNoCopy(

+ NULL,

+ reinterpret_cast<const UInt8*>(in.data()),

+ in_length * sizeof(typename InStringType::value_type),

+ in_encoding,

+ false,

+ kCFAllocatorNull));

if (!cfstring)

return OutStringType();

« no previous file with comments | « base/native_library_mac.mm ('k') | base/time_mac.cc » ('j') | no next file with comments »