chrome/browser/extensions/api/system_info_storage/storage_info_provider_mac.cc - Issue 16917011: mac: Replace base::mac::ScopedCFTypeRef with base::ScopedCFTypeRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/system_info_storage/storage_info_provider_mac.cc

Issue 16917011: mac: Replace base::mac::ScopedCFTypeRef with base::ScopedCFTypeRef. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/file_system/file_system_api.cc ('K') | « chrome/browser/extensions/api/music_manager_private/device_id_mac.cc ('k') | chrome/browser/mac/dock.mm » ('j') | chrome/browser/mac/install_from_dmg.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/system_info_storage/storage_info_provider_mac.cc

diff --git a/chrome/browser/extensions/api/system_info_storage/storage_info_provider_mac.cc b/chrome/browser/extensions/api/system_info_storage/storage_info_provider_mac.cc

index 125152bd8bcfcd2988cade99876853e892652be0..0041224985353f40930d47db3d7c99b5b781623f 100644

--- a/chrome/browser/extensions/api/system_info_storage/storage_info_provider_mac.cc

+++ b/chrome/browser/extensions/api/system_info_storage/storage_info_provider_mac.cc

@@ -105,11 +105,9 @@ void StorageInfoProviderMac::BuildStorageTypeMap() {

for (base::mac::ScopedIOObject<io_service_t> media(IOIteratorNext(iterator));

media;

media.reset(IOIteratorNext(iterator))) {

- base::mac::ScopedCFTypeRef<CFTypeRef> dev_path_cf(

- IORegistryEntryCreateCFProperty(media,

- CFSTR(kIOBSDNameKey),

- kCFAllocatorDefault,

- 0));

+ base::ScopedCFTypeRef<CFTypeRef> dev_path_cf(

+ IORegistryEntryCreateCFProperty(

+ media, CFSTR(kIOBSDNameKey), kCFAllocatorDefault, 0));

if (!dev_path_cf)

continue;

@@ -119,11 +117,9 @@ void StorageInfoProviderMac::BuildStorageTypeMap() {

base::SysCFStringRefToUTF8(

base::mac::CFCast<CFStringRef>(dev_path_cf)));

- base::mac::ScopedCFTypeRef<CFTypeRef> removable_cf(

- IORegistryEntryCreateCFProperty(media,

- CFSTR(kIOMediaEjectableKey),

- kCFAllocatorDefault,

- 0));

+ base::ScopedCFTypeRef<CFTypeRef> removable_cf(

+ IORegistryEntryCreateCFProperty(

+ media, CFSTR(kIOMediaEjectableKey), kCFAllocatorDefault, 0));

if (!removable_cf)

dev_path_to_type_map_[dev_path] = systeminfo::kStorageTypeUnknown;

else if (CFBooleanGetValue(base::mac::CFCast<CFBooleanRef>(removable_cf)))