[MD settings] Language settings layout closer to mocks

[MD settings] Language settings layout closer to mocks

This CL changes the layout of the Language and Input
settings to more closely match the current mocks.
This CL also:
- makes .list-items 40px high at minimum
- removes languages_page.css

BUG=512479
Committed: https://crrev.com/825c18d400a52cb89798d8185cfcba88154abab4
Cr-Commit-Position: refs/heads/master@{#374845}

[dschuyler, 2016-02-11 00:33:39]

dschuyler@chromium.org changed reviewers:
+ michaelpg@chromium.org

[michaelpg, 2016-02-11 01:06:44]

Wow, the mocks have changed quite a bit. Thanks for doing this! I only have
style/formatting nits.

https://codereview.chromium.org/1691633002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/languages_page/languages_page.html
(right):

https://codereview.chromium.org/1691633002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/languages_page/languages_page.html:48:
<iron-icon icon="done"
nit: don't indent inside <if>

https://codereview.chromium.org/1691633002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/languages_page/languages_page.html:50:
item.language.code, prefs.intl.app_locale.value)]]">
The fix for this probably hasn't landed yet.
https://github.com/Polymer/polymer/pull/2486

https://codereview.chromium.org/1691633002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/languages_page/languages_page.html:59: <div
class="list-item list-button"
nit: no newline needed after (i think)

https://codereview.chromium.org/1691633002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/languages_page/languages_page.html:82:
item.id, languages.currentInputMethod)]]">
same issue

https://codereview.chromium.org/1691633002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/languages_page/languages_page.html:89:
i18n-content="manageInputMethods">
nit: 4-space indent

https://codereview.chromium.org/1691633002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/languages_page/languages_page.html:95: <div
class="settings-box two-line">
no indent inside if

https://codereview.chromium.org/1691633002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/languages_page/languages_page.html:114:
i18n-content="manageSpellCheck"
it looks like you are using line breaks aggressively. doesn't this fit on the
previous line (or is rietveld not showing all the spaces)?

https://codereview.chromium.org/1691633002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_shared.css (right):

https://codereview.chromium.org/1691633002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_shared.css:92: /* This button has no
ink ripple */
nit: period. also why is this comment necessary?

[michaelpg, 2016-02-11 01:23:21]

https://codereview.chromium.org/1691633002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/languages_page/languages_page.html
(right):

https://codereview.chromium.org/1691633002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/languages_page/languages_page.html:48:
<iron-icon icon="done"
On 2016/02/11 01:06:44, michaelpg wrote:
> nit: don't indent inside <if>

nvm, this is correct

https://codereview.chromium.org/1691633002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/languages_page/languages_page.html:95: <div
class="settings-box two-line">
On 2016/02/11 01:06:44, michaelpg wrote:
> no indent inside if

nvm

[dschuyler, 2016-02-11 01:30:08]

https://codereview.chromium.org/1691633002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/languages_page/languages_page.html
(right):

https://codereview.chromium.org/1691633002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/languages_page/languages_page.html:48:
<iron-icon icon="done"
On 2016/02/11 01:06:44, michaelpg wrote:
> nit: don't indent inside <if>

I was trying to keep the indent as if the <if>
were not present.  The indent is for being 
inside the <div>.

https://codereview.chromium.org/1691633002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/languages_page/languages_page.html:48:
<iron-icon icon="done"
On 2016/02/11 01:23:21, michaelpg wrote:
> On 2016/02/11 01:06:44, michaelpg wrote:
> > nit: don't indent inside <if>
> 
> nvm, this is correct

Acknowledged.

https://codereview.chromium.org/1691633002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/languages_page/languages_page.html:50:
item.language.code, prefs.intl.app_locale.value)]]">
On 2016/02/11 01:06:44, michaelpg wrote:
> The fix for this probably hasn't landed yet.
> https://github.com/Polymer/polymer/pull/2486

Acknowledged.

https://codereview.chromium.org/1691633002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/languages_page/languages_page.html:59: <div
class="list-item list-button"
On 2016/02/11 01:06:44, michaelpg wrote:
> nit: no newline needed after (i think)

Done.

https://codereview.chromium.org/1691633002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/languages_page/languages_page.html:82:
item.id, languages.currentInputMethod)]]">
On 2016/02/11 01:06:44, michaelpg wrote:
> same issue

Done.

https://codereview.chromium.org/1691633002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/languages_page/languages_page.html:89:
i18n-content="manageInputMethods">
On 2016/02/11 01:06:43, michaelpg wrote:
> nit: 4-space indent

Done.

https://codereview.chromium.org/1691633002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/languages_page/languages_page.html:95: <div
class="settings-box two-line">
On 2016/02/11 01:06:44, michaelpg wrote:
> no indent inside if

Acknowledged.

https://codereview.chromium.org/1691633002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/languages_page/languages_page.html:95: <div
class="settings-box two-line">
On 2016/02/11 01:23:21, michaelpg wrote:
> On 2016/02/11 01:06:44, michaelpg wrote:
> > no indent inside if
> 
> nvm

Acknowledged.

https://codereview.chromium.org/1691633002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/languages_page/languages_page.html:114:
i18n-content="manageSpellCheck"
On 2016/02/11 01:06:44, michaelpg wrote:
> it looks like you are using line breaks aggressively. doesn't this fit on the
> previous line (or is rietveld not showing all the spaces)?

Done.

https://codereview.chromium.org/1691633002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_shared.css (right):

https://codereview.chromium.org/1691633002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_shared.css:92: /* This button has no
ink ripple */
On 2016/02/11 01:06:44, michaelpg wrote:
> nit: period. also why is this comment necessary?

Alan wants some to have ink ripples and others not to.
I was looking for a place to remind myself which 
was which.  I'm fine keeping or removing this comment.
I lean (51%) toward keeping it :)

Done.

[michaelpg, 2016-02-11 01:34:11]

lgtm

https://codereview.chromium.org/1691633002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_shared.css (right):

https://codereview.chromium.org/1691633002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_shared.css:92: /* This button has no
ink ripple */
On 2016/02/11 01:30:08, dschuyler wrote:
> On 2016/02/11 01:06:44, michaelpg wrote:
> > nit: period. also why is this comment necessary?
> 
> Alan wants some to have ink ripples and others not to.
> I was looking for a place to remind myself which 
> was which.  I'm fine keeping or removing this comment.
> I lean (51%) toward keeping it :)

Well, I lean (50.5%) toward removing it. *sigh* I guess you win. :-P

> 
> Done.

[dschuyler, 2016-02-11 02:28:51]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2016-02-11 02:30:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1691633002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1691633002/20001

[commit-bot: I haz the power, 2016-02-11 02:51:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-16 22:34:19]

Description was changed from

==========
[MD settings] Language settings layout closer to mocks

This CL changes the layout of the Language and Input
settings to more closely match the current mocks.
This CL also:
- makes .list-items 40px high at minimum
- removes languages_page.css

BUG=512479
==========

to

==========
[MD settings] Language settings layout closer to mocks

This CL changes the layout of the Language and Input
settings to more closely match the current mocks.
This CL also:
- makes .list-items 40px high at minimum
- removes languages_page.css

BUG=512479

Committed: https://crrev.com/825c18d400a52cb89798d8185cfcba88154abab4
Cr-Commit-Position: refs/heads/master@{#374845}
==========

[commit-bot: I haz the power, 2016-02-16 22:34:19]

Patchset 2 (id:??) landed as
https://crrev.com/825c18d400a52cb89798d8185cfcba88154abab4
Cr-Commit-Position: refs/heads/master@{#374845}