Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1691623002:
Reland: cc: Imagedecodes: Clip the src_rect to the image rect. (Closed)
|
Created:
4 years, 10 months ago by vmpstr Modified:
4 years, 10 months ago Reviewers:
enne (OOO) CC:
chromium-reviews, cc-bugs_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptioncc: Imagedecodes: Clip the src_rect to the image rect.
This patch clips the source rect to the image rect. If the source rect
falls outside of the image rect, then we still allocate enough memory
for the original source rect, although we don't read the pixels into
it, which results in us eventually using uninitialized memory.
R=enne
BUG=585698
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Committed: https://crrev.com/303aa444b7e4881129bf4e56a71139e4a75b17ee
Cr-Commit-Position: refs/heads/master@{#374963}
Committed: https://crrev.com/c52471d9dec240c8d0a88fa98aa1eefeee32e22f
Cr-Commit-Position: refs/heads/master@{#376031}
Patch Set 1 #Patch Set 2 : update #Patch Set 3 : rebase #
Messages
Total messages: 21 (10 generated)
Description was changed from ========== cc: Imagedecodes: Clip the src_rect to the image rect. This patch clips the source rect to the image rect. If the source rect falls outside of the image rect, then we still allocate enough memory for the original source rect, although we don't read the pixels into it, which results in us eventually using uninitialized memory. R=enne BUG=585698 ========== to ========== cc: Imagedecodes: Clip the src_rect to the image rect. This patch clips the source rect to the image rect. If the source rect falls outside of the image rect, then we still allocate enough memory for the original source rect, although we don't read the pixels into it, which results in us eventually using uninitialized memory. R=enne BUG=585698 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
Please take a look.
What happens if the intersection is empty?
On 2016/02/10 23:54:38, enne wrote: > What happens if the intersection is empty? It goes down the "target size is empty" path, which means we skip the image altogether. I've actually had to update the code for this, because we ended up with a low filter quality empty rect, which returns the original image (because we can't handle filter quality). The proper order of checks is to first check if the target size is empty. Added a test for this as well. PTAL
lgtm, thanks!
The CQ bit was checked by vmpstr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691623002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1691023003/ by vmpstr@chromium.org. The reason for reverting is: This is causing crashes on canary. crbug.com/586430.
Message was sent while issue was closed.
Description was changed from ========== cc: Imagedecodes: Clip the src_rect to the image rect. This patch clips the source rect to the image rect. If the source rect falls outside of the image rect, then we still allocate enough memory for the original source rect, although we don't read the pixels into it, which results in us eventually using uninitialized memory. R=enne BUG=585698 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== cc: Imagedecodes: Clip the src_rect to the image rect. This patch clips the source rect to the image rect. If the source rect falls outside of the image rect, then we still allocate enough memory for the original source rect, although we don't read the pixels into it, which results in us eventually using uninitialized memory. R=enne BUG=585698 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
Description was changed from ========== cc: Imagedecodes: Clip the src_rect to the image rect. This patch clips the source rect to the image rect. If the source rect falls outside of the image rect, then we still allocate enough memory for the original source rect, although we don't read the pixels into it, which results in us eventually using uninitialized memory. R=enne BUG=585698 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== Reland: cc: Imagedecodes: Clip the src_rect to the image rect. This patch clips the source rect to the image rect. If the source rect falls outside of the image rect, then we still allocate enough memory for the original source rect, although we don't read the pixels into it, which results in us eventually using uninitialized memory. R=enne BUG=585698 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ==========
Message was sent while issue was closed.
Description was changed from ========== Reland: cc: Imagedecodes: Clip the src_rect to the image rect. This patch clips the source rect to the image rect. If the source rect falls outside of the image rect, then we still allocate enough memory for the original source rect, although we don't read the pixels into it, which results in us eventually using uninitialized memory. R=enne BUG=585698 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel ========== to ========== cc: Imagedecodes: Clip the src_rect to the image rect. This patch clips the source rect to the image rect. If the source rect falls outside of the image rect, then we still allocate enough memory for the original source rect, although we don't read the pixels into it, which results in us eventually using uninitialized memory. R=enne BUG=585698 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/303aa444b7e4881129bf4e56a71139e4a75b17ee Cr-Commit-Position: refs/heads/master@{#374963} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/303aa444b7e4881129bf4e56a71139e4a75b17ee Cr-Commit-Position: refs/heads/master@{#374963}
Message was sent while issue was closed.
Description was changed from ========== cc: Imagedecodes: Clip the src_rect to the image rect. This patch clips the source rect to the image rect. If the source rect falls outside of the image rect, then we still allocate enough memory for the original source rect, although we don't read the pixels into it, which results in us eventually using uninitialized memory. R=enne BUG=585698 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/303aa444b7e4881129bf4e56a71139e4a75b17ee Cr-Commit-Position: refs/heads/master@{#374963} ========== to ========== cc: Imagedecodes: Clip the src_rect to the image rect. This patch clips the source rect to the image rect. If the source rect falls outside of the image rect, then we still allocate enough memory for the original source rect, although we don't read the pixels into it, which results in us eventually using uninitialized memory. R=enne BUG=585698 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/303aa444b7e4881129bf4e56a71139e4a75b17ee Cr-Commit-Position: refs/heads/master@{#374963} ==========
The CQ bit was checked by vmpstr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org Link to the patchset: https://codereview.chromium.org/1691623002/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691623002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691623002/40001
Message was sent while issue was closed.
Description was changed from ========== cc: Imagedecodes: Clip the src_rect to the image rect. This patch clips the source rect to the image rect. If the source rect falls outside of the image rect, then we still allocate enough memory for the original source rect, although we don't read the pixels into it, which results in us eventually using uninitialized memory. R=enne BUG=585698 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/303aa444b7e4881129bf4e56a71139e4a75b17ee Cr-Commit-Position: refs/heads/master@{#374963} ========== to ========== cc: Imagedecodes: Clip the src_rect to the image rect. This patch clips the source rect to the image rect. If the source rect falls outside of the image rect, then we still allocate enough memory for the original source rect, although we don't read the pixels into it, which results in us eventually using uninitialized memory. R=enne BUG=585698 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/303aa444b7e4881129bf4e56a71139e4a75b17ee Cr-Commit-Position: refs/heads/master@{#374963} ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== cc: Imagedecodes: Clip the src_rect to the image rect. This patch clips the source rect to the image rect. If the source rect falls outside of the image rect, then we still allocate enough memory for the original source rect, although we don't read the pixels into it, which results in us eventually using uninitialized memory. R=enne BUG=585698 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/303aa444b7e4881129bf4e56a71139e4a75b17ee Cr-Commit-Position: refs/heads/master@{#374963} ========== to ========== cc: Imagedecodes: Clip the src_rect to the image rect. This patch clips the source rect to the image rect. If the source rect falls outside of the image rect, then we still allocate enough memory for the original source rect, although we don't read the pixels into it, which results in us eventually using uninitialized memory. R=enne BUG=585698 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/303aa444b7e4881129bf4e56a71139e4a75b17ee Cr-Commit-Position: refs/heads/master@{#374963} Committed: https://crrev.com/c52471d9dec240c8d0a88fa98aa1eefeee32e22f Cr-Commit-Position: refs/heads/master@{#376031} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/c52471d9dec240c8d0a88fa98aa1eefeee32e22f Cr-Commit-Position: refs/heads/master@{#376031} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
