Issue 1691603002: Get rid of redundant MockSdk.

Issue 1691603002: Get rid of redundant MockSdk. (Closed)

Created:
4 years, 10 months ago by Bob Nystrom

Modified:
4 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Get rid of redundant MockSdk. The two in src/mock_sdk.dart and src/context/mock_sdk.dart were almost identical. The former was only used in one place, so I made the latter support that case. Also cleaned up a few other minor things I noticed along the way. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/1fb9cebd6e980a9bd6b83c2fe15864691e354b46

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -632 lines)			Patch
M	pkg/analyzer/lib/src/generated/sdk.dart	View		4 chunks	+6 lines, -13 lines	0 comments	Download
M	pkg/analyzer/test/generated/all_the_rest_test.dart	View	1	1 chunk	+0 lines, -26 lines	0 comments	Download
M	pkg/analyzer/test/src/context/mock_sdk.dart	View	1 2	11 chunks	+75 lines, -76 lines	0 comments	Download
D	pkg/analyzer/test/src/mock_sdk.dart	View		1 chunk	+0 lines, -327 lines	0 comments	Download
M	pkg/analyzer/test/src/task/dart_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/test/src/task/strong/strong_test_helper.dart	View	1 2	6 chunks	+5 lines, -189 lines	0 comments	Download

Total messages: 8 (2 generated)

Bob Nystrom

I see there are other mocks floating around now too. I'll get to those in ...

4 years, 10 months ago (2016-02-10 22:13:09 UTC) #3

Bob Nystrom

Actually, hold off on reviewing this. I'll try to get rid of the extra one ...

4 years, 10 months ago (2016-02-11 01:24:49 UTC) #4

Bob Nystrom

4 years, 10 months ago (2016-02-11 23:20:09 UTC) #8

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
1fb9cebd6e980a9bd6b83c2fe15864691e354b46 (presubmit successful).