Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issue 1691533002: third_party/binutils: clarify the procedure to upload the new binaries. (Closed)

Created:
4 years, 10 months ago by krasin
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang, krasin1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

third_party/binutils: clarify the procedure to upload the new binaries. BUG=584828 Committed: https://crrev.com/1ad0a1d1ba53cfe2a8ae3038be80f6ea4cdfadbb Cr-Commit-Position: refs/heads/master@{#374748}

Patch Set 1 #

Total comments: 4

Patch Set 2 : grammar fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/binutils/README.chromium View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
krasin1
Hi Lei, I have added the missing piece to the documentation. That was the only ...
4 years, 10 months ago (2016-02-10 19:29:28 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1691533002/diff/1/third_party/binutils/README.chromium File third_party/binutils/README.chromium (right): https://codereview.chromium.org/1691533002/diff/1/third_party/binutils/README.chromium#newcode47 third_party/binutils/README.chromium:47: * Run upload.sh. Note: you will need a ...
4 years, 10 months ago (2016-02-10 20:17:55 UTC) #3
krasin1
https://codereview.chromium.org/1691533002/diff/1/third_party/binutils/README.chromium File third_party/binutils/README.chromium (right): https://codereview.chromium.org/1691533002/diff/1/third_party/binutils/README.chromium#newcode47 third_party/binutils/README.chromium:47: * Run upload.sh. Note: you will need a write ...
4 years, 10 months ago (2016-02-10 21:36:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691533002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691533002/20001
4 years, 10 months ago (2016-02-10 21:38:56 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-10 22:14:32 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:31:42 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1ad0a1d1ba53cfe2a8ae3038be80f6ea4cdfadbb
Cr-Commit-Position: refs/heads/master@{#374748}

Powered by Google App Engine
This is Rietveld 408576698