sync/internal_api/change_record.cc - Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/change_record.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/proxy/proxy_api_helpers_unittest.cc ('K') | « sync/internal_api/base_node.cc ('k') | sync/internal_api/js_mutation_event_observer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/change_record.cc

diff --git a/sync/internal_api/change_record.cc b/sync/internal_api/change_record.cc

index b3aeb995c7bb867e4510d2fdc36be0822251f7d3..4894b3ce9e24b4da87098ffeab1682dbda183989 100644

--- a/sync/internal_api/change_record.cc

+++ b/sync/internal_api/change_record.cc

@@ -17,8 +17,8 @@ ChangeRecord::ChangeRecord()

ChangeRecord::~ChangeRecord() {}

-DictionaryValue* ChangeRecord::ToValue() const {

- DictionaryValue* value = new DictionaryValue();

+base::DictionaryValue* ChangeRecord::ToValue() const {

+ base::DictionaryValue* value = new base::DictionaryValue();

std::string action_str;

switch (action) {

case ACTION_ADD:

@@ -55,7 +55,7 @@ ExtraPasswordChangeRecordData::ExtraPasswordChangeRecordData(

ExtraPasswordChangeRecordData::~ExtraPasswordChangeRecordData() {}

-DictionaryValue* ExtraPasswordChangeRecordData::ToValue() const {

+base::DictionaryValue* ExtraPasswordChangeRecordData::ToValue() const {

return PasswordSpecificsDataToValue(unencrypted_);

}