Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: sync/api/sync_change_unittest.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/api/sync_change_unittest.cc
diff --git a/sync/api/sync_change_unittest.cc b/sync/api/sync_change_unittest.cc
index b989e41a8b87b4440ea3489b382f559206cb49ca..4c23c771327e3cc9c75228d77d1e112d60d196a2 100644
--- a/sync/api/sync_change_unittest.cc
+++ b/sync/api/sync_change_unittest.cc
@@ -47,8 +47,8 @@ TEST_F(SyncChangeTest, LocalUpdate) {
EXPECT_EQ(tag, e.sync_data().GetTag());
EXPECT_EQ(title, e.sync_data().GetTitle());
EXPECT_EQ(PREFERENCES, e.sync_data().GetDataType());
- scoped_ptr<DictionaryValue> ref_spec(EntitySpecificsToValue(specifics));
- scoped_ptr<DictionaryValue> e_spec(EntitySpecificsToValue(
+ scoped_ptr<base::DictionaryValue> ref_spec(EntitySpecificsToValue(specifics));
+ scoped_ptr<base::DictionaryValue> e_spec(EntitySpecificsToValue(
e.sync_data().GetSpecifics()));
EXPECT_TRUE(ref_spec->Equals(e_spec.get()));
}
@@ -67,8 +67,8 @@ TEST_F(SyncChangeTest, LocalAdd) {
EXPECT_EQ(tag, e.sync_data().GetTag());
EXPECT_EQ(title, e.sync_data().GetTitle());
EXPECT_EQ(PREFERENCES, e.sync_data().GetDataType());
- scoped_ptr<DictionaryValue> ref_spec(EntitySpecificsToValue(specifics));
- scoped_ptr<DictionaryValue> e_spec(EntitySpecificsToValue(
+ scoped_ptr<base::DictionaryValue> ref_spec(EntitySpecificsToValue(specifics));
+ scoped_ptr<base::DictionaryValue> e_spec(EntitySpecificsToValue(
e.sync_data().GetSpecifics()));
EXPECT_TRUE(ref_spec->Equals(e_spec.get()));
}
@@ -110,9 +110,9 @@ TEST_F(SyncChangeTest, SyncerChanges) {
SyncChange e = change_list[0];
EXPECT_EQ(SyncChange::ACTION_UPDATE, e.change_type());
EXPECT_EQ(PREFERENCES, e.sync_data().GetDataType());
- scoped_ptr<DictionaryValue> ref_spec(EntitySpecificsToValue(
+ scoped_ptr<base::DictionaryValue> ref_spec(EntitySpecificsToValue(
update_specifics));
- scoped_ptr<DictionaryValue> e_spec(EntitySpecificsToValue(
+ scoped_ptr<base::DictionaryValue> e_spec(EntitySpecificsToValue(
e.sync_data().GetSpecifics()));
EXPECT_TRUE(ref_spec->Equals(e_spec.get()));

Powered by Google App Engine
This is Rietveld 408576698