Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(891)

Unified Diff: chrome/browser/extensions/menu_manager.h

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/menu_manager.h
diff --git a/chrome/browser/extensions/menu_manager.h b/chrome/browser/extensions/menu_manager.h
index c4e56aced07fa2171fa1df03f970d105c440cf86..764e8616804e82999573476916c753ef0bcbbc94 100644
--- a/chrome/browser/extensions/menu_manager.h
+++ b/chrome/browser/extensions/menu_manager.h
@@ -109,11 +109,11 @@ class MenuItem {
value_ |= context;
}
- scoped_ptr<Value> ToValue() const {
- return scoped_ptr<Value>(Value::CreateIntegerValue(value_));
+ scoped_ptr<base::Value> ToValue() const {
+ return scoped_ptr<base::Value>(base::Value::CreateIntegerValue(value_));
}
- bool Populate(const Value& value) {
+ bool Populate(const base::Value& value) {
int int_value;
if (!value.GetAsInteger(&int_value) || int_value < 0)
return false;
@@ -178,7 +178,7 @@ class MenuItem {
// Returns a new MenuItem created from |value|, or NULL if there is
// an error. The caller takes ownership of the MenuItem.
static MenuItem* Populate(const std::string& extension_id,
- const DictionaryValue& value,
+ const base::DictionaryValue& value,
std::string* error);
// Sets any document and target URL patterns from |properties|.

Powered by Google App Engine
This is Rietveld 408576698