Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1208)

Unified Diff: chrome/browser/extensions/api/storage/settings_test_util.cc

Issue 16915006: Convert most of extensions and some other random stuff to using the base namespace for Values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/storage/settings_test_util.cc
diff --git a/chrome/browser/extensions/api/storage/settings_test_util.cc b/chrome/browser/extensions/api/storage/settings_test_util.cc
index 30bf92b76c7f6eb658ba29264b761c53dbf937d0..3d8d110e787182166d5a771ee1332b1b589910f0 100644
--- a/chrome/browser/extensions/api/storage/settings_test_util.cc
+++ b/chrome/browser/extensions/api/storage/settings_test_util.cc
@@ -60,11 +60,11 @@ void MockExtensionService::AddExtensionWithIdAndPermissions(
const std::string& id,
Manifest::Type type,
const std::set<std::string>& permissions_set) {
- DictionaryValue manifest;
+ base::DictionaryValue manifest;
manifest.SetString("name", std::string("Test extension ") + id);
manifest.SetString("version", "1.0");
- scoped_ptr<ListValue> permissions(new ListValue());
+ scoped_ptr<base::ListValue> permissions(new base::ListValue());
for (std::set<std::string>::const_iterator it = permissions_set.begin();
it != permissions_set.end(); ++it) {
permissions->Append(Value::CreateStringValue(*it));
@@ -76,8 +76,8 @@ void MockExtensionService::AddExtensionWithIdAndPermissions(
break;
case Manifest::TYPE_LEGACY_PACKAGED_APP: {
- DictionaryValue* app = new DictionaryValue();
- DictionaryValue* app_launch = new DictionaryValue();
+ base::DictionaryValue* app = new base::DictionaryValue();
+ base::DictionaryValue* app_launch = new base::DictionaryValue();
app_launch->SetString("local_path", "fake.html");
app->Set("launch", app_launch);
manifest.Set("app", app);

Powered by Google App Engine
This is Rietveld 408576698