Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 1691453002: Fix flakiness of ExecuteScriptApiTest.FrameWithHttp204 (Closed)

Created:
4 years, 10 months ago by robwu
Modified:
4 years, 10 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Charlie Reis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flakiness of ExecuteScriptApiTest.FrameWithHttp204 BUG=585471 Committed: https://crrev.com/91e1a50d7a74d1a8d9ac6f81cca394a826d14354 Cr-Commit-Position: refs/heads/master@{#374798}

Patch Set 1 #

Patch Set 2 : [1][2] = [1][0][2] #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -3 lines) Patch
M chrome/test/data/extensions/api_test/executescript/http204/background.js View 1 1 chunk +17 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
robwu
4 years, 10 months ago (2016-02-10 21:51:59 UTC) #2
Charlie Reis
I'm pretty rusty on extension test code. Nasko, can you review? (Side note: Any chance ...
4 years, 10 months ago (2016-02-10 22:00:12 UTC) #4
robwu
On 2016/02/10 22:00:12, Charlie Reis wrote: > I'm pretty rusty on extension test code. Nasko, ...
4 years, 10 months ago (2016-02-10 22:14:56 UTC) #7
ncarter (slow)
lgtm (though it would be nicer, of course, to force the race to resolve in ...
4 years, 10 months ago (2016-02-10 22:21:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691453002/20001
4 years, 10 months ago (2016-02-10 22:25:55 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-11 00:12:02 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:33:03 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/91e1a50d7a74d1a8d9ac6f81cca394a826d14354
Cr-Commit-Position: refs/heads/master@{#374798}

Powered by Google App Engine
This is Rietveld 408576698