Make --abort_on_assertion_errors more selective.

runtime/vm/exceptions.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/exceptions.h"
 
 #include "platform/address_sanitizer.h"
 
 #include "vm/dart_api_impl.h"
 #include "vm/dart_entry.h"
 #include "vm/debugger.h"
 #include "vm/flags.h"
 #include "vm/object.h"
 #include "vm/object_store.h"
 #include "vm/stack_frame.h"
 #include "vm/stub_code.h"
 #include "vm/symbols.h"
 #include "vm/tags.h"
 
 namespace dart {
 
+// TODO(vegorov): Remove --abort_on_assertion_errors flag and associated
+// infrastructure (dartbug.com/25753)
 DEFINE_FLAG(bool, abort_on_assertion_errors, false,
             "Abort on assertion and typecheck failures");
 DEFINE_FLAG(bool, print_stacktrace_at_throw, false,
             "Prints a stack trace everytime a throw occurs.");
 
 
 const char* Exceptions::kCastErrorDstName = "type cast";
 
 
 class StacktraceBuilder : public ValueObject {
@@ skipping 648 matching lines @@
 
 // Throw JavascriptCompatibilityError exception.
 void Exceptions::ThrowJavascriptCompatibilityError(const char* msg) {
   const Array& exc_args = Array::Handle(Array::New(1));
   const String& msg_str = String::Handle(String::New(msg));
   exc_args.SetAt(0, msg_str);
   Exceptions::ThrowByType(Exceptions::kJavascriptCompatibilityError, exc_args);
 }
 
 
+static bool IsLikelyInternalDart2JSCrash(const Stacktrace& stacktrace) {
+  Function& function = Function::Handle();
+  String& name = String::Handle();
+  for (intptr_t i = 0, len = stacktrace.Length(); i < len; i++) {
+    function = stacktrace.FunctionAtFrame(i);
+    name = function.QualifiedPrettyName();
+    if (name.Equals("_CompilerDiagnosticReporter.withCurrentElement")) {
+      return true;
+    }
+  }
+  return false;
+}
+
+
 void Exceptions::PrintStackTraceAndAbort(const char* reason) {
-  const Instance& stacktrace = Instance::Handle(CurrentStacktrace());
+  const Stacktrace& stacktrace = Stacktrace::Handle(CurrentStacktrace());
+  if (!IsLikelyInternalDart2JSCrash(stacktrace)) {
+    return;
+  }
 
   OS::PrintErr("\n\n\nAborting due to %s. Stacktrace:\n%s\n",
                reason,
                stacktrace.ToCString());
   OS::Abort();
 }
 
 }  // namespace dart