Make --abort_on_assertion_errors more selective.

Make --abort_on_assertion_errors more selective.

Only abort() if we detect that we have likely encountered internal Dart2JS
compiler error.

This flag was added in attempt to gather more information on buildbots but
it turns out that always aborting on type/assertion errors does not scale:
some dart2js tests actually test that an error was thrown.

BUG=http://dartbug.com/25753
R=srdjan@google.com, whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/03d2a819e47bbf82ce6972eeac5206df7d99cee7

[Vyacheslav Egorov (Google), 2016-02-10 17:06:48]

Description was changed from

==========
Make --abort_on_assertion_errors more selective.

Only abort() if we detect that we have likely encountered internal Dart2JS
compiler error.

This flag was added in attempt to gather more information on buildbots but
it turns out that always aborting on type/assertion errors does not scale:
some dart2js tests actually test that an error was thrown.

BUG=
==========

to

==========
Make --abort_on_assertion_errors more selective.

Only abort() if we detect that we have likely encountered internal Dart2JS
compiler error.

This flag was added in attempt to gather more information on buildbots but
it turns out that always aborting on type/assertion errors does not scale:
some dart2js tests actually test that an error was thrown.

BUG=
==========

[Vyacheslav Egorov (Google), 2016-02-10 17:06:48]

vegorov@google.com changed reviewers:
+ srdjan@google.com, whesse@google.com

[Vyacheslav Egorov (Google), 2016-02-10 17:07:13]

Please take a look

[srdjan, 2016-02-10 17:20:34]

Could you mark this with a TODO, to be removed, or do you want to make it more
general with flags?

[Bill Hesse, 2016-02-10 17:24:04]

The status line, and the TODO to remove this code, should have an issue number,
and an issue should be filed.  LGTM after that.

[Vyacheslav Egorov (Google), 2016-02-10 17:35:36]

Description was changed from

==========
Make --abort_on_assertion_errors more selective.

Only abort() if we detect that we have likely encountered internal Dart2JS
compiler error.

This flag was added in attempt to gather more information on buildbots but
it turns out that always aborting on type/assertion errors does not scale:
some dart2js tests actually test that an error was thrown.

BUG=
==========

to

==========
Make --abort_on_assertion_errors more selective.

Only abort() if we detect that we have likely encountered internal Dart2JS
compiler error.

This flag was added in attempt to gather more information on buildbots but
it turns out that always aborting on type/assertion errors does not scale:
some dart2js tests actually test that an error was thrown.

BUG=http://dartbug.com/25753
==========

[Vyacheslav Egorov (Google), 2016-02-10 17:36:09]

Filed issue, added TODOs. 

PTAL

[srdjan, 2016-02-10 17:38:51]

lgtm

[Vyacheslav Egorov (Google), 2016-02-10 17:49:12]

Description was changed from

==========
Make --abort_on_assertion_errors more selective.

Only abort() if we detect that we have likely encountered internal Dart2JS
compiler error.

This flag was added in attempt to gather more information on buildbots but
it turns out that always aborting on type/assertion errors does not scale:
some dart2js tests actually test that an error was thrown.

BUG=http://dartbug.com/25753
==========

to

==========
Make --abort_on_assertion_errors more selective.

Only abort() if we detect that we have likely encountered internal Dart2JS
compiler error.

This flag was added in attempt to gather more information on buildbots but
it turns out that always aborting on type/assertion errors does not scale:
some dart2js tests actually test that an error was thrown.

BUG=http://dartbug.com/25753
R=srdjan@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/03d2a819e47bbf82ce6972eeac5206df7d99cee7
==========

[Vyacheslav Egorov (Google), 2016-02-10 17:49:14]

Committed patchset #2 (id:20001) manually as
03d2a819e47bbf82ce6972eeac5206df7d99cee7 (presubmit successful).