Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1691433002:
[Interpreter] Rename GetCountOperand to GetRegisterCountOperand. (Closed)
|
Created:
4 years, 10 months ago by Stefano Sanfilippo Modified:
4 years, 10 months ago CC:
v8-reviews_googlegroups.com, oth Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionReland of [Interpreter] Rename GetCountOperand to GetRegisterCountOperand.
Apparently, this BytecodeArrayIterator method was missed during the
previous refactor. No other (collateral) change was done.
BUG=v8:4280
LOG=N
Committed: https://crrev.com/2f0ac9a2cd72325a738f846c241cdb39518a5782
Cr-Commit-Position: refs/heads/master@{#33909}
Patch Set 1 : #Patch Set 2 : Solve collision between CLs in flight. #
Messages
Total messages: 50 (30 generated)
Patchset #1 (id:1) has been deleted
ssanfilippo@chromium.org changed reviewers: + oth@chromium.org, rmcilroy@google.com
As rmcilroy asked, I renamed GetCountOperand to GetRegisterCountOperand. PTAL.
ssanfilippo@chromium.org changed reviewers: + rmcilroy@chromium.org - rmcilroy@google.com
The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691433002/20001
LGTM, thanks!
You will need to get an owner of /src/compiler to approve the change in that directory.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== [Interpreter] Rename GetCountOperand to GetRegisterCountOperand. Apparently, this BytecodeArrayIterator method was missed during the previous refactor. No other (collateral) change was done. BUG=v8:4280 LOG=N ========== to ========== [Interpreter] Rename GetCountOperand to GetRegisterCountOperand. Apparently, this BytecodeArrayIterator method was missed during the previous refactor. No other (collateral) change was done. BUG=v8:4280 LOG=N ==========
ssanfilippo@chromium.org changed reviewers: + mstarzinger@chromium.org
lgtm.
LGTM (rubber-stamp of "compiler" piece).
The CQ bit was checked by ssanfilippo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691433002/20001
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Rename GetCountOperand to GetRegisterCountOperand. Apparently, this BytecodeArrayIterator method was missed during the previous refactor. No other (collateral) change was done. BUG=v8:4280 LOG=N ========== to ========== [Interpreter] Rename GetCountOperand to GetRegisterCountOperand. Apparently, this BytecodeArrayIterator method was missed during the previous refactor. No other (collateral) change was done. BUG=v8:4280 LOG=N ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Rename GetCountOperand to GetRegisterCountOperand. Apparently, this BytecodeArrayIterator method was missed during the previous refactor. No other (collateral) change was done. BUG=v8:4280 LOG=N ========== to ========== [Interpreter] Rename GetCountOperand to GetRegisterCountOperand. Apparently, this BytecodeArrayIterator method was missed during the previous refactor. No other (collateral) change was done. BUG=v8:4280 LOG=N Committed: https://crrev.com/3781ca79f5c48b55d7f0bf6df370ec11515a1466 Cr-Commit-Position: refs/heads/master@{#33897} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/3781ca79f5c48b55d7f0bf6df370ec11515a1466 Cr-Commit-Position: refs/heads/master@{#33897}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:20001) has been created in https://codereview.chromium.org/1690963002/ by machenbach@chromium.org. The reason for reverting is: [Sheriff] Breaks the tree: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20builder/buil... Blamelists are wrong because of overloaded master. The trybots on this CL might have been outdated by the time of commit... Please rebase and retry..
Message was sent while issue was closed.
Description was changed from ========== [Interpreter] Rename GetCountOperand to GetRegisterCountOperand. Apparently, this BytecodeArrayIterator method was missed during the previous refactor. No other (collateral) change was done. BUG=v8:4280 LOG=N Committed: https://crrev.com/3781ca79f5c48b55d7f0bf6df370ec11515a1466 Cr-Commit-Position: refs/heads/master@{#33897} ========== to ========== Reland of [Interpreter] Rename GetCountOperand to GetRegisterCountOperand. (patchset #1 id:20001 of https://codereview.chromium.org/1691433002/ ) Reason for revert: [Sheriff] Breaks the tree: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20builder/buil... Blamelists are wrong because of overloaded master. The trybots on this CL might have been outdated by the time of commit... Please rebase and retry. Original issue's description: > [Interpreter] Rename GetCountOperand to GetRegisterCountOperand. > > Apparently, this BytecodeArrayIterator method was missed during the > previous refactor. No other (collateral) change was done. > > BUG=v8:4280 > LOG=N > > Committed: https://crrev.com/3781ca79f5c48b55d7f0bf6df370ec11515a1466 > Cr-Commit-Position: refs/heads/master@{#33897} TBR=oth@chromium.org,rmcilroy@chromium.org,mstarzinger@chromium.org,ssanfilip... # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280 ==========
The CQ bit was checked by oth@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691433002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691433002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Reland of [Interpreter] Rename GetCountOperand to GetRegisterCountOperand. (patchset #1 id:20001 of https://codereview.chromium.org/1691433002/ ) Reason for revert: [Sheriff] Breaks the tree: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20builder/buil... Blamelists are wrong because of overloaded master. The trybots on this CL might have been outdated by the time of commit... Please rebase and retry. Original issue's description: > [Interpreter] Rename GetCountOperand to GetRegisterCountOperand. > > Apparently, this BytecodeArrayIterator method was missed during the > previous refactor. No other (collateral) change was done. > > BUG=v8:4280 > LOG=N > > Committed: https://crrev.com/3781ca79f5c48b55d7f0bf6df370ec11515a1466 > Cr-Commit-Position: refs/heads/master@{#33897} TBR=oth@chromium.org,rmcilroy@chromium.org,mstarzinger@chromium.org,ssanfilip... # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280 ========== to ========== Reland of [Interpreter] Rename GetCountOperand to GetRegisterCountOperand. (patchset #1 id:20001 of https://codereview.chromium.org/1691433002/ ) Revert message: > Reason for revert: > [Sheriff] Breaks the tree: > https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20builder/buil... > > Blamelists are wrong because of overloaded master. The trybots on this CL might have been outdated by the time of commit... Please rebase and retry. > > Original issue's description: > > [Interpreter] Rename GetCountOperand to GetRegisterCountOperand. > > > > Apparently, this BytecodeArrayIterator method was missed during the > > previous refactor. No other (collateral) change was done. > > > > BUG=v8:4280 > > LOG=N > > > > Committed: https://crrev.com/3781ca79f5c48b55d7f0bf6df370ec11515a1466 > > Cr-Commit-Position: refs/heads/master@{#33897} > > TBR=oth@chromium.org,rmcilroy@chromium.org,mstarzinger@chromium.org,ssanfilip... > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4280 BUG=v8:4280 LOG=N ==========
Description was changed from ========== Reland of [Interpreter] Rename GetCountOperand to GetRegisterCountOperand. (patchset #1 id:20001 of https://codereview.chromium.org/1691433002/ ) Revert message: > Reason for revert: > [Sheriff] Breaks the tree: > https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20builder/buil... > > Blamelists are wrong because of overloaded master. The trybots on this CL might have been outdated by the time of commit... Please rebase and retry. > > Original issue's description: > > [Interpreter] Rename GetCountOperand to GetRegisterCountOperand. > > > > Apparently, this BytecodeArrayIterator method was missed during the > > previous refactor. No other (collateral) change was done. > > > > BUG=v8:4280 > > LOG=N > > > > Committed: https://crrev.com/3781ca79f5c48b55d7f0bf6df370ec11515a1466 > > Cr-Commit-Position: refs/heads/master@{#33897} > > TBR=oth@chromium.org,rmcilroy@chromium.org,mstarzinger@chromium.org,ssanfilip... > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4280 BUG=v8:4280 LOG=N ========== to ========== Reland of [Interpreter] Rename GetCountOperand to GetRegisterCountOperand. (patchset #1 id:20001 of https://codereview.chromium.org/1691433002/ ) Revert message: > Reason for revert: > [Sheriff] Breaks the tree: > https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20builder/buil... > > Blamelists are wrong because of overloaded master. The trybots on this CL might have been outdated by the time of commit... Please rebase and retry. > > Original issue's description: > > [Interpreter] Rename GetCountOperand to GetRegisterCountOperand. > > > > Apparently, this BytecodeArrayIterator method was missed during the > > previous refactor. No other (collateral) change was done. > > > > BUG=v8:4280 > > LOG=N > > > > Committed: https://crrev.com/3781ca79f5c48b55d7f0bf6df370ec11515a1466 > > Cr-Commit-Position: refs/heads/master@{#33897} > > TBR=oth@chromium.org,rmcilroy@chromium.org,mstarzinger@chromium.org,ssanfilip... > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4280 BUG=v8:4280 LOG=N ==========
The CQ bit was checked by ssanfilippo@chromium.org to run a CQ dry run
The CQ bit was unchecked by ssanfilippo@chromium.org
The CQ bit was checked by ssanfilippo@chromium.org to run a CQ dry run
The CQ bit was unchecked by ssanfilippo@chromium.org
The CQ bit was checked by ssanfilippo@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691433002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691433002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ssanfilippo@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from oth@chromium.org, rmcilroy@chromium.org, mstarzinger@chromium.org Link to the patchset: https://codereview.chromium.org/1691433002/#ps40001 (title: "Solve collision between CLs in flight.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691433002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691433002/40001
The CQ bit was unchecked by ssanfilippo@chromium.org
Description was changed from ========== Reland of [Interpreter] Rename GetCountOperand to GetRegisterCountOperand. (patchset #1 id:20001 of https://codereview.chromium.org/1691433002/ ) Revert message: > Reason for revert: > [Sheriff] Breaks the tree: > https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20builder/buil... > > Blamelists are wrong because of overloaded master. The trybots on this CL might have been outdated by the time of commit... Please rebase and retry. > > Original issue's description: > > [Interpreter] Rename GetCountOperand to GetRegisterCountOperand. > > > > Apparently, this BytecodeArrayIterator method was missed during the > > previous refactor. No other (collateral) change was done. > > > > BUG=v8:4280 > > LOG=N > > > > Committed: https://crrev.com/3781ca79f5c48b55d7f0bf6df370ec11515a1466 > > Cr-Commit-Position: refs/heads/master@{#33897} > > TBR=oth@chromium.org,rmcilroy@chromium.org,mstarzinger@chromium.org,ssanfilip... > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4280 BUG=v8:4280 LOG=N ========== to ========== Reland of [Interpreter] Rename GetCountOperand to GetRegisterCountOperand. Apparently, this BytecodeArrayIterator method was missed during the previous refactor. No other (collateral) change was done. BUG=v8:4280 LOG=N ==========
Description was changed from ========== Reland of [Interpreter] Rename GetCountOperand to GetRegisterCountOperand. Apparently, this BytecodeArrayIterator method was missed during the previous refactor. No other (collateral) change was done. BUG=v8:4280 LOG=N ========== to ========== Reland [Interpreter] Rename GetCountOperand to GetRegisterCountOperand. Apparently, this BytecodeArrayIterator method was missed during the previous refactor. No other (collateral) change was done. BUG=v8:4280 LOG=N ==========
The CQ bit was checked by ssanfilippo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691433002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691433002/40001
Description was changed from ========== Reland [Interpreter] Rename GetCountOperand to GetRegisterCountOperand. Apparently, this BytecodeArrayIterator method was missed during the previous refactor. No other (collateral) change was done. BUG=v8:4280 LOG=N ========== to ========== Reland of [Interpreter] Rename GetCountOperand to GetRegisterCountOperand. Apparently, this BytecodeArrayIterator method was missed during the previous refactor. No other (collateral) change was done. BUG=v8:4280 LOG=N ==========
Message was sent while issue was closed.
Description was changed from ========== Reland of [Interpreter] Rename GetCountOperand to GetRegisterCountOperand. Apparently, this BytecodeArrayIterator method was missed during the previous refactor. No other (collateral) change was done. BUG=v8:4280 LOG=N ========== to ========== Reland of [Interpreter] Rename GetCountOperand to GetRegisterCountOperand. Apparently, this BytecodeArrayIterator method was missed during the previous refactor. No other (collateral) change was done. BUG=v8:4280 LOG=N ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Reland of [Interpreter] Rename GetCountOperand to GetRegisterCountOperand. Apparently, this BytecodeArrayIterator method was missed during the previous refactor. No other (collateral) change was done. BUG=v8:4280 LOG=N ========== to ========== Reland of [Interpreter] Rename GetCountOperand to GetRegisterCountOperand. Apparently, this BytecodeArrayIterator method was missed during the previous refactor. No other (collateral) change was done. BUG=v8:4280 LOG=N Committed: https://crrev.com/2f0ac9a2cd72325a738f846c241cdb39518a5782 Cr-Commit-Position: refs/heads/master@{#33909} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/2f0ac9a2cd72325a738f846c241cdb39518a5782 Cr-Commit-Position: refs/heads/master@{#33909} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
