Source/core/rendering/svg/SVGPathData.cpp - Issue 16914003: Fix SVG animations which set rx or ry attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/SVGPathData.cpp

Issue 16914003: Fix SVG animations which set rx or ry attributes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/svg/SVGPathData.cpp

diff --git a/Source/core/rendering/svg/SVGPathData.cpp b/Source/core/rendering/svg/SVGPathData.cpp

index af95a60187bfccb6e2762c9867bd92b32c78694e..0879b8b831ece367f6f7cfeb2fe3fe680a0d25bb 100644

--- a/Source/core/rendering/svg/SVGPathData.cpp

+++ b/Source/core/rendering/svg/SVGPathData.cpp

@@ -124,8 +124,8 @@ static void updatePathFromRectElement(SVGElement* element, Path& path)

return;

float x = rect->x().value(lengthContext);

float y = rect->y().value(lengthContext);

- bool hasRx = rect->hasAttribute(SVGNames::rxAttr);

- bool hasRy = rect->hasAttribute(SVGNames::ryAttr);

+ bool hasRx = rect->rx().value(lengthContext) > 0;

+ bool hasRy = rect->ry().value(lengthContext) > 0;

if (hasRx || hasRy) {

float rx = rect->rx().value(lengthContext);

float ry = rect->ry().value(lengthContext);