Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1691333002: PlzNavigate: support for srcdoc navigations (Closed)

Created:
4 years, 10 months ago by clamy
Modified:
4 years, 10 months ago
Reviewers:
nasko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, blink-reviews, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, carlosk
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: support for srcdoc navigations This CL introduces support for srcdoc navigations. They are no longer sent to the browser, as they make no netwrok request. On commit, the created NavigationHandle is also made properly aware that the navigation was an srcdoc navigation. BUG=576263 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/5d1d4e4db330d84655b921d0c9e83c44ea69ddbb Cr-Commit-Position: refs/heads/master@{#375456}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -15 lines) Patch
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/frame_messages.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/common/navigation_params.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M testing/buildbot/filters/browser-side-navigation.linux.content_browsertests.filter View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
clamy
@nasko: PTAL https://codereview.chromium.org/1691333002/diff/1/content/common/frame_messages.h File content/common/frame_messages.h (right): https://codereview.chromium.org/1691333002/diff/1/content/common/frame_messages.h#newcode292 content/common/frame_messages.h:292: IPC_STRUCT_MEMBER(bool, is_srcdoc) I'm sending is_srcdoc as a ...
4 years, 10 months ago (2016-02-12 16:11:30 UTC) #4
nasko
LGTM with a nit. https://codereview.chromium.org/1691333002/diff/1/content/common/frame_messages.h File content/common/frame_messages.h (right): https://codereview.chromium.org/1691333002/diff/1/content/common/frame_messages.h#newcode291 content/common/frame_messages.h:291: // True if the navigation ...
4 years, 10 months ago (2016-02-12 17:11:57 UTC) #5
clamy
Thanks! https://codereview.chromium.org/1691333002/diff/1/content/common/frame_messages.h File content/common/frame_messages.h (right): https://codereview.chromium.org/1691333002/diff/1/content/common/frame_messages.h#newcode291 content/common/frame_messages.h:291: // True if the navigation originated as an ...
4 years, 10 months ago (2016-02-15 12:37:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691333002/20001
4 years, 10 months ago (2016-02-15 12:38:17 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-15 14:06:06 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:50:00 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5d1d4e4db330d84655b921d0c9e83c44ea69ddbb
Cr-Commit-Position: refs/heads/master@{#375456}

Powered by Google App Engine
This is Rietveld 408576698