src/IceTargetLoweringMIPS32.cpp - Issue 1691193002: Subzero: Prototype to make use of RegNumT::No Register more concise

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLoweringMIPS32.cpp

Issue 1691193002: Subzero: Prototype to make use of RegNumT::No Register more concise (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: changes suggested by stichnot Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceTargetLoweringMIPS32.cpp

diff --git a/src/IceTargetLoweringMIPS32.cpp b/src/IceTargetLoweringMIPS32.cpp

index e34dd5d86c675ed01d2129c57e1aaa0bb63088f3..4313d2726852aeef6ca5242a8cc9894e41ba73c2 100644

--- a/src/IceTargetLoweringMIPS32.cpp

+++ b/src/IceTargetLoweringMIPS32.cpp

@@ -360,7 +360,7 @@ Variable *TargetMIPS32::makeReg(Type Type, RegNumT RegNum) {

// There aren't any 64-bit integer registers for Mips32.

assert(Type != IceType_i64);

Variable *Reg = Func->makeVariable(Type);

- if (RegNum == RegNumT::NoRegister)

+ if (RegNum.hasValue())

Reg->setMustHaveReg();

else

Reg->setRegNum(RegNum);

« src/IceOperand.h ('K') | « src/IceOperand.h ('k') | no next file » | no next file with comments »