src/IceRegistersARM32.h - Issue 1691193002: Subzero: Prototype to make use of RegNumT::No Register more concise

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceRegistersARM32.h

Issue 1691193002: Subzero: Prototype to make use of RegNumT::No Register more concise (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: changes suggested by stichnot Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceRegistersARM32.h

diff --git a/src/IceRegistersARM32.h b/src/IceRegistersARM32.h

index 6e3c56264a98d9e23065493e4eb7e616c3ad1b2b..8941a9e770a6fd2bb5fb392be3e4c6b26064ddef 100644

--- a/src/IceRegistersARM32.h

+++ b/src/IceRegistersARM32.h

@@ -104,7 +104,7 @@ extern struct RegTableType {

static inline void assertValidRegNum(RegNumT RegNum) {

(void)RegNum;

- assert(RegNum != RegNumT::NoRegister);

+ assert(RegNum.hasValue());

}

static inline bool isGPRegister(RegNumT RegNum) {

« no previous file with comments | « src/IceRegAlloc.cpp ('k') | src/IceTargetLoweringARM32.h » ('j') | no next file with comments »