Subzero: Prototype to make use of RegNumT::No Register more concise

src/IceOperand.cpp

 //===- subzero/src/IceOperand.cpp - High-level operand implementation -----===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 183 matching lines @@
 }
 
 const Variable *Variable::asType(Type Ty, RegNumT NewRegNum) const {
   // Note: This returns a Variable, even if the "this" object is a subclass of
   // Variable.
   if (!BuildDefs::dump() || getType() == Ty)
     return this;
   Variable *V = new (getCurrentCfgAllocator()->Allocate<Variable>())
       Variable(kVariable, Ty, Number);
   V->NameIndex = NameIndex;
-  V->RegNum = NewRegNum == RegNumT::NoRegister ? RegNum : NewRegNum;
+  V->RegNum = NewRegNum.hasNoValue() ? RegNum : NewRegNum;

[Jim Stichnoth, 2016/02/12 18:29:54]

NewRegNum.hasValue() ? NewRegNum : RegNum

similar to how
  if (c) a(); else b();
is preferred over
  if (!c) b(); else a();

[rkotlerimgtec, 2016/02/12 22:02:01]

Done.

   V->StackOffset = StackOffset;
   return V;
 }
 
 RegWeight Variable::getWeight(const Cfg *Func) const {
   VariablesMetadata *VMetadata = Func->getVMetadata();
   return mustHaveReg() ? RegWeight(RegWeight::Inf)
                        : mustNotHaveReg() ? RegWeight(RegWeight::Zero)
                                           : VMetadata->getUseWeight(this);
 }
@@ skipping 402 matching lines @@
   if (getType() != IceType_i32 && getType() != IceType_i16 &&
       getType() != IceType_i8)
     return false;
   // The Following checks if the signed representation of Value is between
   // -Threshold/2 and +Threshold/2
   bool largerThanThreshold = Threshold / 2 + Value >= Threshold;
   return largerThanThreshold;
 }
 
 } // end of namespace Ice