Subzero: Prototype to make use of RegNumT::No Register more concise

src/IceOperand.h

 //===- subzero/src/IceOperand.h - High-level operands -----------*- C++ -*-===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 425 matching lines @@
     // Make sure it's only called once.
     assert(Limit == 0);
     assert(Value != 0);
     Limit = Value;
   }
   // Define NoRegisterValue as an enum value so that it can be used as an
   // argument for the public ctor if desired.
   enum { NoRegisterValue = std::numeric_limits<BaseType>::max() };
   const static RegNumT NoRegister /* = NoRegisterValue */;
 
+  bool hasValue() const {return Value == NoRegisterValue;}

[Jim Stichnoth, 2016/02/12 03:16:51]

You really need "return Value != NoRegisterValue;" to convey the meaning of
hasValue(), which is the opposite of your original noRegister() proposal.

+
 private:
   BaseType Value = NoRegisterValue;
   static BaseType Limit;
   /// Private ctor called only by fromInt() and fixme().
   RegNumT(BaseType Value) : Value(Value) { validate(Value); }
   /// The ctor calls this to validate against the target-supplied limit.
   static void validate(BaseType Value) {
     (void)Value;
     assert(Value == NoRegisterValue || Value < Limit);
   }
@@ skipping 467 matching lines @@
 private:
   const Cfg *Func;
   MetadataKind Kind;
   CfgVector<VariableTracking> Metadata;
   const static InstDefList NoDefinitions;
 };
 
 } // end of namespace Ice
 
 #endif // SUBZERO_SRC_ICEOPERAND_H