cc: Consider main thread making deadline upon abort.

cc: Consider main thread making deadline upon abort.

This resets main_thread_missed_deadline in BeginMainFrameAborted,
which prevents latency recovery logic from skipping a frame
immediately after an aborted frame, since an aborted frame
is effectively already a skipped frame.

BUG=582749
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/18474c0ee0dc26d66216e7f0cabd5776a4110cb0
Cr-Commit-Position: refs/heads/master@{#375723}

[brianderson, 2016-02-11 22:52:38]

Description was changed from

==========
cc: Consider main thread making deadline upon abort.

This resets main_thread_missed_deadline in BeginMainFrameAborted,
which prevents latency recovery logic from skipping a frame
immediately after an aborted frame, since an aborted frame
is effectively already a skipped frame.

BUG=582749
==========

to

==========
cc: Consider main thread making deadline upon abort.

This resets main_thread_missed_deadline in BeginMainFrameAborted,
which prevents latency recovery logic from skipping a frame
immediately after an aborted frame, since an aborted frame
is effectively already a skipped frame.

BUG=582749
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[brianderson, 2016-02-16 21:46:54]

brianderson@chromium.org changed reviewers:
+ sunnyps@chromium.org

[brianderson, 2016-02-16 21:46:54]

Ptal.

This is a small patch split out from https://codereview.chromium.org/1681393003

[sunnyps, 2016-02-16 22:02:20]

LGTM with nits

https://codereview.chromium.org/1691153002/diff/20001/cc/scheduler/scheduler_...
File cc/scheduler/scheduler_unittest.cc (right):

https://codereview.chromium.org/1691153002/diff/20001/cc/scheduler/scheduler_...
cc/scheduler/scheduler_unittest.cc:1501: EXPECT_ACTION("AddObserver(this)",
client_, 0, 3);
nit: Move these EXPECT_ACTION calls to below AdvanceFrame() because that is when
these actions happen.

https://codereview.chromium.org/1691153002/diff/20001/cc/scheduler/scheduler_...
cc/scheduler/scheduler_unittest.cc:1518:
EXPECT_TRUE(client_->HasAction("ScheduledActionSendBeginMainFrame"));
nit: same here.

[brianderson, 2016-02-16 23:08:42]

https://codereview.chromium.org/1691153002/diff/20001/cc/scheduler/scheduler_...
File cc/scheduler/scheduler_unittest.cc (right):

https://codereview.chromium.org/1691153002/diff/20001/cc/scheduler/scheduler_...
cc/scheduler/scheduler_unittest.cc:1501: EXPECT_ACTION("AddObserver(this)",
client_, 0, 3);
On 2016/02/16 22:02:20, sunnyps wrote:
> nit: Move these EXPECT_ACTION calls to below AdvanceFrame() because that is
when
> these actions happen.

Done.

https://codereview.chromium.org/1691153002/diff/20001/cc/scheduler/scheduler_...
cc/scheduler/scheduler_unittest.cc:1518:
EXPECT_TRUE(client_->HasAction("ScheduledActionSendBeginMainFrame"));
On 2016/02/16 22:02:20, sunnyps wrote:
> nit: same here.

Done.

[brianderson, 2016-02-16 23:08:45]

The CQ bit was checked by brianderson@chromium.org

[brianderson, 2016-02-16 23:08:46]

The patchset sent to the CQ was uploaded after l-g-t-m from sunnyps@chromium.org
Link to the patchset: https://codereview.chromium.org/1691153002/#ps40001
(title: "reorder expectations")

[commit-bot: I haz the power, 2016-02-16 23:09:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1691153002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1691153002/40001

[commit-bot: I haz the power, 2016-02-17 00:23:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-17 00:24:40]

Description was changed from

==========
cc: Consider main thread making deadline upon abort.

This resets main_thread_missed_deadline in BeginMainFrameAborted,
which prevents latency recovery logic from skipping a frame
immediately after an aborted frame, since an aborted frame
is effectively already a skipped frame.

BUG=582749
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc: Consider main thread making deadline upon abort.

This resets main_thread_missed_deadline in BeginMainFrameAborted,
which prevents latency recovery logic from skipping a frame
immediately after an aborted frame, since an aborted frame
is effectively already a skipped frame.

BUG=582749
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/18474c0ee0dc26d66216e7f0cabd5776a4110cb0
Cr-Commit-Position: refs/heads/master@{#375723}
==========

[commit-bot: I haz the power, 2016-02-17 00:24:40]

Patchset 3 (id:??) landed as
https://crrev.com/18474c0ee0dc26d66216e7f0cabd5776a4110cb0
Cr-Commit-Position: refs/heads/master@{#375723}