Add plumbing in blink to allow overriding the skia font manager.

Add plumbing in blink to allow overriding the skia font manager. This allows Chromium to use a custom font collection with skia, without having to patch the vtable of the DirectWrite factory.

BUG=

patch from issue 1591883002 at patchset 300001 (http://crrev.com/1591883002#ps300001)

Committed: https://crrev.com/3f0cbf682e7dfe5ee8ebc171e473cece02c6c3cc
Cr-Commit-Position: refs/heads/master@{#375714}

[Ilya Kulshin, 2016-02-11 20:40:18]

https://codereview.chromium.org/1691073002/diff/1/skia/config/sk_ref_cnt_ext_...
File skia/config/sk_ref_cnt_ext_debug.h (right):

https://codereview.chromium.org/1691073002/diff/1/skia/config/sk_ref_cnt_ext_...
skia/config/sk_ref_cnt_ext_debug.h:28: private:
Note: the actual change here is moving adopted() and requireAdoption() to be
private. deref() is unchanged.

[Ilya Kulshin, 2016-02-12 00:10:50]

kulshin@chromium.org changed reviewers:
+ bungeman@chromium.org, pfeldman@chromium.org, scottmg@chromium.org

[Ilya Kulshin, 2016-02-12 00:10:51]

Attempt #2 at landing https://codereview.chromium.org/1591883002/, after fixing
the release-only break.

scottmg@ - please give owners approval for content/child/*
pfeldman@ - please give owners approval for third_party/webkit/*
bungmena@ - please review skia/config/*

[scottmg, 2016-02-12 00:36:59]

unchanged from previous attempt -> lgtm

[bungeman-skia, 2016-02-12 15:45:10]

bungeman@google.com changed reviewers:
+ bungeman@google.com

[bungeman-skia, 2016-02-12 15:45:11]

https://codereview.chromium.org/1691073002/diff/40001/skia/config/sk_ref_cnt_...
File skia/config/sk_ref_cnt_ext_release.h (right):

https://codereview.chromium.org/1691073002/diff/40001/skia/config/sk_ref_cnt_...
skia/config/sk_ref_cnt_ext_release.h:18: namespace WTF {
Is there a reason for adding any of this? WTF::adopted(void*) always exists and
already does nothing, and in release doesn't need to do anything.

https://codereview.chromium.org/1691073002/diff/40001/skia/config/sk_ref_cnt_...
skia/config/sk_ref_cnt_ext_release.h:23: using WTF::adopted;
Are these needed? I would prefer these be removed and the corresponding ones in
the _debug.h version be removed as well, if possible. If this doesn't have a
demonstrated use case, it's just needlessly polluting the global namespace. I
can put together a CL separately to remove them from the _debug.h file, but I
wouldn't add this here if it isn't necessary.

[Ilya Kulshin, 2016-02-12 20:47:10]

https://codereview.chromium.org/1691073002/diff/40001/skia/config/sk_ref_cnt_...
File skia/config/sk_ref_cnt_ext_release.h (right):

https://codereview.chromium.org/1691073002/diff/40001/skia/config/sk_ref_cnt_...
skia/config/sk_ref_cnt_ext_release.h:18: namespace WTF {
On 2016/02/12 15:45:11, bungeman1 wrote:
> Is there a reason for adding any of this? WTF::adopted(void*) always exists
and
> already does nothing, and in release doesn't need to do anything.

I don't want to force callers to rely on a different component, just to call
these APIs. Since the debug build exposes these functions, I think the release
build should make them available as well. At the very least this makes it
clearer what happens in release vs debug.

https://codereview.chromium.org/1691073002/diff/40001/skia/config/sk_ref_cnt_...
skia/config/sk_ref_cnt_ext_release.h:23: using WTF::adopted;
On 2016/02/12 15:45:11, bungeman1 wrote:
> Are these needed? I would prefer these be removed and the corresponding ones
in
> the _debug.h version be removed as well, if possible. If this doesn't have a
> demonstrated use case, it's just needlessly polluting the global namespace. I
> can put together a CL separately to remove them from the _debug.h file, but I
> wouldn't add this here if it isn't necessary.

I tried removing them, but that caused a bunch of breaks and would require
changes that should be in a separate change.

[bungeman-skia, 2016-02-12 20:55:32]

On 2016/02/12 20:47:10, Ilya Kulshin wrote:
>
https://codereview.chromium.org/1691073002/diff/40001/skia/config/sk_ref_cnt_...
> File skia/config/sk_ref_cnt_ext_release.h (right):
> 
>
https://codereview.chromium.org/1691073002/diff/40001/skia/config/sk_ref_cnt_...
> skia/config/sk_ref_cnt_ext_release.h:18: namespace WTF {
> On 2016/02/12 15:45:11, bungeman1 wrote:
> > Is there a reason for adding any of this? WTF::adopted(void*) always exists
> and
> > already does nothing, and in release doesn't need to do anything.
> 
> I don't want to force callers to rely on a different component, just to call
> these APIs. Since the debug build exposes these functions, I think the release
> build should make them available as well. At the very least this makes it
> clearer what happens in release vs debug.
> 
>
https://codereview.chromium.org/1691073002/diff/40001/skia/config/sk_ref_cnt_...
> skia/config/sk_ref_cnt_ext_release.h:23: using WTF::adopted;
> On 2016/02/12 15:45:11, bungeman1 wrote:
> > Are these needed? I would prefer these be removed and the corresponding ones
> in
> > the _debug.h version be removed as well, if possible. If this doesn't have a
> > demonstrated use case, it's just needlessly polluting the global namespace.
I
> > can put together a CL separately to remove them from the _debug.h file, but
I
> > wouldn't add this here if it isn't necessary.
> 
> I tried removing them, but that caused a bunch of breaks and would require
> changes that should be in a separate change.

Ok, I'll see about removing this bit of cruft at some point later then. lgtm.

[pfeldman, 2016-02-16 21:56:29]

public lgtm

[Ilya Kulshin, 2016-02-16 22:07:26]

The CQ bit was checked by kulshin@chromium.org

[Ilya Kulshin, 2016-02-16 22:07:27]

The patchset sent to the CQ was uploaded after l-g-t-m from scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/1691073002/#ps40001
(title: "Merge to head")

[commit-bot: I haz the power, 2016-02-16 22:08:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1691073002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1691073002/40001

[commit-bot: I haz the power, 2016-02-17 00:09:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-17 00:10:24]

Description was changed from

==========
Add plumbing in blink to allow overriding the skia font manager. This allows
Chromium to use a custom font collection with skia, without having to patch the
vtable of the DirectWrite factory.

BUG=

patch from issue 1591883002 at patchset 300001
(http://crrev.com/1591883002#ps300001)
==========

to

==========
Add plumbing in blink to allow overriding the skia font manager. This allows
Chromium to use a custom font collection with skia, without having to patch the
vtable of the DirectWrite factory.

BUG=

patch from issue 1591883002 at patchset 300001
(http://crrev.com/1591883002#ps300001)

Committed: https://crrev.com/3f0cbf682e7dfe5ee8ebc171e473cece02c6c3cc
Cr-Commit-Position: refs/heads/master@{#375714}
==========

[commit-bot: I haz the power, 2016-02-17 00:10:25]

Patchset 3 (id:??) landed as
https://crrev.com/3f0cbf682e7dfe5ee8ebc171e473cece02c6c3cc
Cr-Commit-Position: refs/heads/master@{#375714}