Make copyTextTo() of text iterators check the length parameter

Make copyTextTo() of text iterators check the length parameter

This CL makes |copyTextTo()| function shrinks the |minLength| parameter
to |length() - position| if it exceeds that value.

This CL will be utilized by a follow-up CL:

crrev.com/1678803002

BUG=n/a
TEST=n/a; no behavior change

Committed: https://crrev.com/3c1491ceac9b05efd7d6170e4a4222eb9be2598f
Cr-Commit-Position: refs/heads/master@{#375154}

[Xiaocheng, 2016-02-12 04:21:38]

Description was changed from

==========
Make copyTextTo() of text iterators check the length parameter

This CL makes |copyTextTo()| function shrinks the |minLength| parameter
to |length() - position| if it exceeds that value.

This CL will be utilized by a follow-up CL:



BUG=n/a
TEST=n/a; no behavior change
==========

to

==========
Make copyTextTo() of text iterators check the length parameter

This CL makes |copyTextTo()| function shrinks the |minLength| parameter
to |length() - position| if it exceeds that value.

This CL will be utilized by a follow-up CL:

crrev.com/1678803002

BUG=n/a
TEST=n/a; no behavior change
==========

[Xiaocheng, 2016-02-12 06:18:22]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-02-12 06:18:22]

PTAL.

[yosin_UTC9, 2016-02-12 08:28:18]

lgtm

I think using |start|+|end| is better than |position|+|length| and cleaner code.

https://codereview.chromium.org/1691053004/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp
(right):

https://codereview.chromium.org/1691053004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp:416:
if (position + minLength > length())
int end = std::min(position + minLength, length());
if (isBetweenSurrogatePair(end))
  ++end;
int copiedLength = end - position;
copyCodeUnitsTo(output, position, copiedLength);

[Xiaocheng, 2016-02-12 08:44:07]

Yeah, it appears that (start, end) gives cleaner code. As this change affects
quite some code, I'll do it in another patch.

https://codereview.chromium.org/1691053004/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp
(right):

https://codereview.chromium.org/1691053004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/iterators/SimplifiedBackwardsTextIterator.cpp:416:
if (position + minLength > length())
On 2016/02/12 at 08:28:18, Yosi_UTC9 wrote:
> int end = std::min(position + minLength, length());
> if (isBetweenSurrogatePair(end))
>   ++end;
> int copiedLength = end - position;
> copyCodeUnitsTo(output, position, copiedLength);

Done.

[Xiaocheng, 2016-02-12 08:45:32]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2016-02-12 08:45:32]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/1691053004/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-02-12 08:45:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1691053004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1691053004/20001

[commit-bot: I haz the power, 2016-02-12 10:17:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-16 22:42:31]

Description was changed from

==========
Make copyTextTo() of text iterators check the length parameter

This CL makes |copyTextTo()| function shrinks the |minLength| parameter
to |length() - position| if it exceeds that value.

This CL will be utilized by a follow-up CL:

crrev.com/1678803002

BUG=n/a
TEST=n/a; no behavior change
==========

to

==========
Make copyTextTo() of text iterators check the length parameter

This CL makes |copyTextTo()| function shrinks the |minLength| parameter
to |length() - position| if it exceeds that value.

This CL will be utilized by a follow-up CL:

crrev.com/1678803002

BUG=n/a
TEST=n/a; no behavior change

Committed: https://crrev.com/3c1491ceac9b05efd7d6170e4a4222eb9be2598f
Cr-Commit-Position: refs/heads/master@{#375154}
==========

[commit-bot: I haz the power, 2016-02-16 22:42:31]

Patchset 2 (id:??) landed as
https://crrev.com/3c1491ceac9b05efd7d6170e4a4222eb9be2598f
Cr-Commit-Position: refs/heads/master@{#375154}