Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1691043002: In summary/stats.dart, don't count enums with index == 0. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

In summary/stats.dart, don't count enums with index == 0. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/2a129906a9233402dda68671c31f2bd67b730551

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M pkg/analyzer/tool/summary/stats.dart View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 10 months ago (2016-02-11 19:00:59 UTC) #2
scheglov
LGTM
4 years, 10 months ago (2016-02-11 19:02:17 UTC) #3
Paul Berry
4 years, 10 months ago (2016-02-11 19:02:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2a129906a9233402dda68671c31f2bd67b730551 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698