Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1691033002: Fix table size in flatbuffers. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -2 lines) Patch
M pkg/analyzer/lib/src/summary/flat_buffers.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/flat_buffers_test.dart View 2 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 10 months ago (2016-02-11 18:52:00 UTC) #2
scheglov
LGTM
4 years, 10 months ago (2016-02-11 18:54:42 UTC) #3
Paul Berry
4 years, 10 months ago (2016-02-11 19:05:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4726810f052966caf4a5ce8f0255e40e99eecc66 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698