Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 1691023003: Revert of cc: Imagedecodes: Clip the src_rect to the image rect. (Closed)

Created:
4 years, 10 months ago by vmpstr
Modified:
4 years, 10 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Imagedecodes: Clip the src_rect to the image rect. (patchset #2 id:20001 of https://codereview.chromium.org/1691623002/ ) Reason for revert: This is causing crashes on canary. crbug.com/586430 Original issue's description: > cc: Imagedecodes: Clip the src_rect to the image rect. > > This patch clips the source rect to the image rect. If the source rect > falls outside of the image rect, then we still allocate enough memory > for the original source rect, although we don't read the pixels into > it, which results in us eventually using uninitialized memory. > > R=enne > BUG=585698 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=enne@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=585698 Committed: https://crrev.com/ea840cce5370feee1ffbc75c7625c9dc682da9d1 Cr-Commit-Position: refs/heads/master@{#375194}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -121 lines) Patch
M cc/tiles/image_decode_controller.cc View 4 chunks +9 lines, -16 lines 0 comments Download
M cc/tiles/image_decode_controller_unittest.cc View 3 chunks +0 lines, -105 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
vmpstr
Created Revert of cc: Imagedecodes: Clip the src_rect to the image rect.
4 years, 10 months ago (2016-02-12 16:59:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691023003/1
4 years, 10 months ago (2016-02-12 16:59:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 17:00:45 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:43:31 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea840cce5370feee1ffbc75c7625c9dc682da9d1
Cr-Commit-Position: refs/heads/master@{#375194}

Powered by Google App Engine
This is Rietveld 408576698