Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1691023002:
[CT] Use zips of SKPs to speed up "isolate tests" (Closed)
Description[CT] Use zips of SKPs to speed up "isolate tests".
Context: The isolate binary is slow when it deals with >100k files (see https://github.com/luci/luci-go/issues/9)
This change compresses the 1M SKPs into 100 zip files.
BUG=
Committed: https://crrev.com/f1c547700d6bf1cf3db43611f154c8f3f1ea1541
Cr-Commit-Position: refs/heads/master@{#375026}
Patch Set 1 : Initial upload #Patch Set 2 : Rename zip #Patch Set 3 : Fix #
Messages
Total messages: 23 (10 generated)
Description was changed from ========== Checkpoint BUG= ========== to ========== [CT] Use zips of SKPs to speed up "isolate tests". Context: The isolate binary is slow when it deals with >100k files (see https://github.com/luci/luci-go/issues/9) This change compresses the 1M SKPs into 100 zip files. BUG= ==========
rmistry@google.com changed reviewers: + maruel@chromium.org
Where is the part that compresses?
On 2016/02/11 20:50:23, M-A Ruel wrote: > Where is the part that compresses? In this CL: https://codereview.chromium.org/1689093004/
On 2016/02/11 20:53:10, rmistry wrote: > On 2016/02/11 20:50:23, M-A Ruel wrote: > > Where is the part that compresses? > > In this CL: https://codereview.chromium.org/1689093004/ Oh, this means that the build will be broken for a moment. Oh well. lgtm
The CQ bit was checked by rmistry@google.com to run a CQ dry run
On 2016/02/11 20:55:01, M-A Ruel wrote: > On 2016/02/11 20:53:10, rmistry wrote: > > On 2016/02/11 20:50:23, M-A Ruel wrote: > > > Where is the part that compresses? > > > > In this CL: https://codereview.chromium.org/1689093004/ > > Oh, this means that the build will be broken for a moment. Oh well. Yea, I will do my best to land at the same time. > > lgtm
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691023002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691023002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by rmistry@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691023002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691023002/40001
The CQ bit was unchecked by rmistry@google.com
rmistry@chromium.org changed reviewers: + rmistry@chromium.org
lgtm
The CQ bit was checked by rmistry@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691023002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691023002/40001
Message was sent while issue was closed.
Description was changed from ========== [CT] Use zips of SKPs to speed up "isolate tests". Context: The isolate binary is slow when it deals with >100k files (see https://github.com/luci/luci-go/issues/9) This change compresses the 1M SKPs into 100 zip files. BUG= ========== to ========== [CT] Use zips of SKPs to speed up "isolate tests". Context: The isolate binary is slow when it deals with >100k files (see https://github.com/luci/luci-go/issues/9) This change compresses the 1M SKPs into 100 zip files. BUG= ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1692153002/ by rmistry@chromium.org. The reason for reverting is: The zipping and unzipping process seems to take longer than the isolate binary did for >100k files. Reverting this experiment. I am instead going to break up the "isolate tests" steps into multiple steps if >100k files..
Message was sent while issue was closed.
Description was changed from ========== [CT] Use zips of SKPs to speed up "isolate tests". Context: The isolate binary is slow when it deals with >100k files (see https://github.com/luci/luci-go/issues/9) This change compresses the 1M SKPs into 100 zip files. BUG= ========== to ========== [CT] Use zips of SKPs to speed up "isolate tests". Context: The isolate binary is slow when it deals with >100k files (see https://github.com/luci/luci-go/issues/9) This change compresses the 1M SKPs into 100 zip files. BUG= Committed: https://crrev.com/f1c547700d6bf1cf3db43611f154c8f3f1ea1541 Cr-Commit-Position: refs/heads/master@{#375026} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/f1c547700d6bf1cf3db43611f154c8f3f1ea1541 Cr-Commit-Position: refs/heads/master@{#375026} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
