Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 1691003003: Remaining page height should never be 0 when told to AssociateWithLatterPage. (Closed)

Created:
4 years, 10 months ago by mstensho (USE GERRIT)
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remaining page height should never be 0 when told to AssociateWithLatterPage. However, the laws of nature behave differently as LayoutUnit approaches infinity. Just use the fragmentainer height instead of zero, but assert that we're actually dealing with saturated arithmetic. BUG=524882 Committed: https://crrev.com/3e04625f97ad0ae12a02e5f4b4d1e40973d01d29 Cr-Commit-Position: refs/heads/master@{#375059}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, --1 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/infinitely-tall-content-in-outer-crash.html View 1 chunk +13 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/multicol/infinitely-tall-content-in-outer-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
4 years, 10 months ago (2016-02-11 22:15:22 UTC) #2
leviw_travelin_and_unemployed
lgtm
4 years, 10 months ago (2016-02-12 00:13:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1691003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1691003003/1
4 years, 10 months ago (2016-02-12 00:14:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 00:23:22 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:40:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e04625f97ad0ae12a02e5f4b4d1e40973d01d29
Cr-Commit-Position: refs/heads/master@{#375059}

Powered by Google App Engine
This is Rietveld 408576698