Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: documentation/filesystem_access.txt

Issue 1690983004: Extended restricted filesystem to support relative paths. (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/trusted/service_runtime/sel_ldr_filename.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: documentation/filesystem_access.txt
diff --git a/documentation/filesystem_access.txt b/documentation/filesystem_access.txt
index b7016de87c8c73dcaf0091c99b98bfb78d499a4b..23a804219db3ce7ca86dc57da25f17e1cf8b33e9 100644
--- a/documentation/filesystem_access.txt
+++ b/documentation/filesystem_access.txt
@@ -16,7 +16,6 @@ be guaranteed by the caller:
* The mounted directory is assumed to not include any symlinks.
These constraints will be enforced by sel_ldr:
- * Pathnames must be absolute. Relative pathnames are explicitly disallowed.
* Pathnames may not include the substring "..".
* Access to filesystem within sel_ldr will behave as if as if the mounted
directory is root.
@@ -68,11 +67,11 @@ Given that strategy, the following syscall changes were straightforward:
### Path sanitization
-Path sanitization happens through a three stage process:
+Path sanitization checks that the cwd is within the mounted directory (set at
+initialization).
-1) Ensure the user's path is absolute.
-2) Prefix the path to the mounted directory.
-3) Ensure that the path does not contain "..".
+If the user's path is absolute, prefix the path to the mounted directory.
+Ensure that the path does not contain "..".
### Symlinks
« no previous file with comments | « no previous file | src/trusted/service_runtime/sel_ldr_filename.c » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698