Reland of Make instrumentation_test_apk depend on their apk_under_test.

build/android/gyp/write_build_config.py

 #!/usr/bin/env python
 #
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Writes a build_config file.
 
 The build_config file for a target is a json file containing information about
 how to build that target based on the target's dependencies. This includes
@@ skipping 405 matching lines @@
 
   proguard_enabled = options.proguard_enabled
   if options.type == 'android_apk':
     deps_info['proguard_enabled'] = proguard_enabled
 
   if proguard_enabled:
     deps_info['proguard_info'] = options.proguard_info
     config['proguard'] = {}
     proguard_config = config['proguard']
     proguard_config['input_paths'] = [options.jar_path] + java_full_classpath
-    proguard_config['tested_apk_info'] = ''
 
   # An instrumentation test apk should exclude the dex files that are in the apk
   # under test.
   if options.type == 'android_apk' and options.tested_apk_config:
     tested_apk_library_deps = tested_apk_deps.All('java_library')
     tested_apk_deps_dex_files = [c['dex_path'] for c in tested_apk_library_deps]
     # Include in the classpath classes that are added directly to the apk under
     # test (those that are not a part of a java_library).
     tested_apk_config = GetDepConfig(options.tested_apk_config)
     javac_classpath.append(tested_apk_config['jar_path'])
     # Exclude dex files from the test apk that exist within the apk under test.
     deps_dex_files = [
         p for p in deps_dex_files if not p in tested_apk_deps_dex_files]
 
     expected_tested_package = tested_apk_config['package_name']
     AndroidManifest(options.android_manifest).CheckInstrumentation(
         expected_tested_package)
     if tested_apk_config['proguard_enabled']:
       assert proguard_enabled, ('proguard must be enabled for instrumentation'
           ' apks if it\'s enabled for the tested apk')
-      proguard_config['tested_apk_info'] = tested_apk_config['proguard_info']

[jbudorick, 2016/02/12 15:33:23]

What's the reasoning behind removing this? I can't tell (or, tbh, tell where
it's used...)

[agrieve, 2016/02/12 15:47:11]

It aligns with the change to the proguard rule in GN.

The "why change it this way", is that I thought it was just a bit too subtle the
way it was. By enforcing that build configs store only values for themselves, it
forces the GN rules to have to reach into apk_under_test's build_config to get
this value. This makes it more obvious in the GN rules that the dependency
exists.

[jbudorick, 2016/02/12 16:33:28]

Makes sense.

 
   # Dependencies for the final dex file of an apk or a 'deps_dex'.
   if options.type in ['android_apk', 'deps_dex']:
     config['final_dex'] = {}
     dex_config = config['final_dex']
     dex_config['dependency_dex_files'] = deps_dex_files
 
   if options.type in ('java_binary', 'java_library', 'android_apk'):
     config['javac']['classpath'] = javac_classpath
     config['java'] = {
@@ skipping 53 matching lines @@
   build_utils.WriteJson(config, options.build_config, only_if_changed=True)
 
   if options.depfile:
     build_utils.WriteDepfile(
         options.depfile,
         deps.AllConfigPaths() + build_utils.GetPythonDependencies())
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv[1:]))