Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 1690963002: Revert of [Interpreter] Rename GetCountOperand to GetRegisterCountOperand. (Closed)

Created:
4 years, 10 months ago by Michael Achenbach
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [Interpreter] Rename GetCountOperand to GetRegisterCountOperand. (patchset #1 id:20001 of https://codereview.chromium.org/1691433002/ ) Reason for revert: [Sheriff] Breaks the tree: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20builder/builds/13892 Blamelists are wrong because of overloaded master. The trybots on this CL might have been outdated by the time of commit... Please rebase and retry. Original issue's description: > [Interpreter] Rename GetCountOperand to GetRegisterCountOperand. > > Apparently, this BytecodeArrayIterator method was missed during the > previous refactor. No other (collateral) change was done. > > BUG=v8:4280 > LOG=N > > Committed: https://crrev.com/3781ca79f5c48b55d7f0bf6df370ec11515a1466 > Cr-Commit-Position: refs/heads/master@{#33897} TBR=oth@chromium.org,rmcilroy@chromium.org,mstarzinger@chromium.org,ssanfilippo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280 Committed: https://crrev.com/4e95426ae65572514ebc80e42742f981de3ccd5b Cr-Commit-Position: refs/heads/master@{#33900}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M src/interpreter/bytecode-array-iterator.h View 1 chunk +1 line, -1 line 0 comments Download
M src/interpreter/bytecode-array-iterator.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-iterator-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [Interpreter] Rename GetCountOperand to GetRegisterCountOperand.
4 years, 10 months ago (2016-02-11 14:13:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690963002/1
4 years, 10 months ago (2016-02-11 14:13:21 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 14:13:33 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 14:14:21 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e95426ae65572514ebc80e42742f981de3ccd5b
Cr-Commit-Position: refs/heads/master@{#33900}

Powered by Google App Engine
This is Rietveld 408576698