Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 1690953002: [runtime/heap] Introduce CopyFixedArrayUpTo to match CopyFixedArrayAndGrow, copying to a smaller ar… (Closed)

Created:
4 years, 10 months ago by Toon Verwaest
Modified:
4 years, 10 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime/heap] Introduce CopyFixedArrayUpTo to match CopyFixedArrayAndGrow, copying to a smaller array. This allows the helper to avoid write barriers while copying, speeding up Object.keys by 5-10%. BUG= Committed: https://crrev.com/2646b62a5c2d393cf97f2128d5c0300473971a8c Cr-Commit-Position: refs/heads/master@{#33916}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -13 lines) Patch
M src/builtins.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/factory.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/factory.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +25 lines, -3 lines 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Toon Verwaest
ptal
4 years, 10 months ago (2016-02-11 14:06:03 UTC) #2
Michael Lippautz
LGTM
4 years, 10 months ago (2016-02-11 14:17:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690953002/1
4 years, 10 months ago (2016-02-11 14:27:37 UTC) #5
commit-bot: I haz the power
Failed to commit the patch.
4 years, 10 months ago (2016-02-11 15:17:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690953002/1
4 years, 10 months ago (2016-02-11 18:57:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 18:58:58 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 18:59:27 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2646b62a5c2d393cf97f2128d5c0300473971a8c
Cr-Commit-Position: refs/heads/master@{#33916}

Powered by Google App Engine
This is Rietveld 408576698