Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 169093004: Don't perform a microtask checkpoint for document.write('<script><\/script>') (Closed)

Created:
6 years, 10 months ago by philipj_slow
Modified:
6 years, 10 months ago
Reviewers:
tkent, rafaelw
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Visibility:
Public.

Description

Don't perform a microtask checkpoint for document.write('<script><\/script>') This is a willful violation of the spec, expecting that it will change: https://www.w3.org/Bugs/Public/show_bug.cgi?id=24361 BUG=340322 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167302

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M LayoutTests/fast/dom/MutationObserver/script-end-tag.html View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/html/parser/HTMLScriptRunner.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
philipj_slow
6 years, 10 months ago (2014-02-17 05:34:15 UTC) #1
rafaelw
lgtm. thanks.
6 years, 10 months ago (2014-02-17 23:24:59 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 10 months ago (2014-02-18 02:27:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/169093004/1
6 years, 10 months ago (2014-02-18 02:27:49 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-18 02:49:01 UTC) #5
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=16167
6 years, 10 months ago (2014-02-18 02:49:01 UTC) #6
philipj_slow
tkent, can you provide core owner LGTM for this?
6 years, 10 months ago (2014-02-18 04:05:09 UTC) #7
tkent
lgtm
6 years, 10 months ago (2014-02-18 04:07:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/169093004/1
6 years, 10 months ago (2014-02-18 04:08:13 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 04:23:23 UTC) #10
Message was sent while issue was closed.
Change committed as 167302

Powered by Google App Engine
This is Rietveld 408576698