Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1690923002:
[runtime] Speed up allocating instances in the runtime by having a quick-check for inobject slack t… (Closed)
|
Created:
4 years, 10 months ago by Toon Verwaest Modified:
4 years, 10 months ago CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[runtime] Speed up allocating instances in the runtime by having a quick-check for inobject slack tracking.
This speeds up
https://github.com/kpdecker/six-speed/blob/master/tests/object-assign/object-assign.es5
by over 5%.
Committed: https://crrev.com/c2aa8f38b061aed593d0b9693e765912c9bbb11c
Cr-Commit-Position: refs/heads/master@{#33917}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #
Messages
Total messages: 29 (14 generated)
verwaest@chromium.org changed reviewers: + ishell@chromium.org, mlippautz@chromium.org
ptal
lgtm
LGTM
The CQ bit was checked by verwaest@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690923002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/15292)
The CQ bit was checked by verwaest@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org, mlippautz@chromium.org Link to the patchset: https://codereview.chromium.org/1690923002/#ps20001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690923002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/1233) v8_linux_dbg_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)
The CQ bit was checked by verwaest@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690923002/20001
The CQ bit was unchecked by verwaest@chromium.org
The CQ bit was checked by verwaest@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690923002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690923002/20001
The CQ bit was checked by verwaest@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org, mlippautz@chromium.org Link to the patchset: https://codereview.chromium.org/1690923002/#ps40001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690923002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690923002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Failed to commit the patch.
On 2016/02/11 15:22:24, commit-bot: I haz the power wrote: > Failed to commit the patch. You should try harder, commit-bot!
The CQ bit was checked by verwaest@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690923002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690923002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [runtime] Speed up allocating instances in the runtime by having a quick-check for inobject slack tracking. This speeds up https://github.com/kpdecker/six-speed/blob/master/tests/object-assign/object-... by over 5%. ========== to ========== [runtime] Speed up allocating instances in the runtime by having a quick-check for inobject slack tracking. This speeds up https://github.com/kpdecker/six-speed/blob/master/tests/object-assign/object-... by over 5%. Committed: https://crrev.com/c2aa8f38b061aed593d0b9693e765912c9bbb11c Cr-Commit-Position: refs/heads/master@{#33917} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/c2aa8f38b061aed593d0b9693e765912c9bbb11c Cr-Commit-Position: refs/heads/master@{#33917} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
