Turn off the tip for the sytem tray menu and the app list (ChromeOS).

Turn off the tip for the sytem tray menu and the app list (ChromeOS).

BUG=245016
TEST=visual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206628

[Mr4D (OOO till 08-26), 2013-06-13 02:05:45]

Please have a look!

[James Cook, 2013-06-13 15:57:09]

LGTM but can you please tie this to the flag harry is introducing in
https://codereview.chromium.org/16900002/ ?  You'll have to wait for his thing
to land, sorry.

I want all the highlight/arrow changes to happen simultaneously, so we get a
highlight that helps compensate for the lack of the arrow.

[Mr4D (OOO till 08-26), 2013-06-13 16:24:35]

Ahhh! That makes sense. I did like the arrows and was not too happy to remove
them without any visual replacement.

[Mr4D (OOO till 08-26), 2013-06-14 20:35:51]

msw, could you please do an owners review? Thanks!

[msw, 2013-06-14 21:53:03]

https://codereview.chromium.org/16909006/diff/5001/ui/views/bubble/bubble_del...
File ui/views/bubble/bubble_delegate.cc (right):

https://codereview.chromium.org/16909006/diff/5001/ui/views/bubble/bubble_del...
ui/views/bubble/bubble_delegate.cc:282:
GetBubbleFrameView()->bubble_border()->set_paint_arrow(paint_type);
This should probably call SizeToContents(). If the bubble is already showing and
changes from NORMAL/TRANSPARENT (reserving space for the arrow) to NONE (no
space is reserved for the arrow) or vice versa, then the overall bubble position
and widget size would change.

[Mr4D (OOO till 08-26), 2013-06-15 02:16:23]

PLease have another look.

https://codereview.chromium.org/16909006/diff/5001/ui/views/bubble/bubble_del...
File ui/views/bubble/bubble_delegate.cc (right):

https://codereview.chromium.org/16909006/diff/5001/ui/views/bubble/bubble_del...
ui/views/bubble/bubble_delegate.cc:282:
GetBubbleFrameView()->bubble_border()->set_paint_arrow(paint_type);
On 2013/06/14 21:53:03, msw wrote:
> This should probably call SizeToContents(). If the bubble is already showing
and
> changes from NORMAL/TRANSPARENT (reserving space for the arrow) to NONE (no
> space is reserved for the arrow) or vice versa, then the overall bubble
position
> and widget size would change.

Done.

[msw, 2013-06-15 02:19:40]

LGTM; thanks!

[commit-bot: I haz the power, 2013-06-15 02:31:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/16909006/10001

[commit-bot: I haz the power, 2013-06-15 05:02:30]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[simonhong_, 2013-06-15 15:21:07]

https://codereview.chromium.org/16909006/diff/10001/ash/system/tray/system_tr...
File ash/system/tray/system_tray.cc (right):

https://codereview.chromium.org/16909006/diff/10001/ash/system/tray/system_tr...
ash/system/tray/system_tray.cc:96: }
This code is actually changing PAINT_NORMAL to PAINT_NONE after
creating(showing) the bubble. (tray bubble is created at the ctor of
TrayBubbleWrapper).
I think setting the arrow before the bubble_view_->InitializeAndShowBubble() is
better than here.

[commit-bot: I haz the power, 2013-06-16 00:51:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/skuhne@chromium.org/16909006/10001

[commit-bot: I haz the power, 2013-06-16 03:16:58]

Change committed as 206628