Fix overlay scrollbar's response to gesture events.

Fix overlay scrollbar's response to gesture events.

BUG=249160
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208383

[Jun Mukai, 2013-06-13 00:58:23]

https://codereview.chromium.org/16909002/diff/1/ui/views/controls/scrollbar/o...
File ui/views/controls/scrollbar/overlay_scroll_bar.cc (right):

https://codereview.chromium.org/16909002/diff/1/ui/views/controls/scrollbar/o...
ui/views/controls/scrollbar/overlay_scroll_bar.cc:65: int alpha =
kThumbDefaultAlpha;
The scrollbar is always shown on my environment (Chromebook Pixel).
I think you'll need to care about STATE_NORMAL here.

[dewittj, 2013-06-13 15:03:28]

I think I forgot to premultiply the alpha value on NORMAL state. PTAL.

[Jun Mukai, 2013-06-13 19:11:23]

https://codereview.chromium.org/16909002/diff/4001/ui/views/controls/scrollba...
File ui/views/controls/scrollbar/overlay_scroll_bar.cc (right):

https://codereview.chromium.org/16909002/diff/4001/ui/views/controls/scrollba...
ui/views/controls/scrollbar/overlay_scroll_bar.cc:131: animation_.Hide();
The scrollbar doesn't hide when I fling the scroll view.  It seems that
ET_SCROLL_FLING_START is triggered in that case.

Unfortunately FLING doesn't have END event, which means you'll probably have to
have a timer for closing. Or that's fine to just close immediately, since the
scrollbar doesn't support velocity-move for fling right now.

Another approach is to catch the ET_TOUCH_PRESSED/ET_TOUCH_RELEASED
OnTouchEvent, this will need to add some handler to ScrollView though.

Either is fine to me.

[dewittj, 2013-06-21 18:53:36]

Jun, could you try this new patch for me?

[dewittj, 2013-06-21 18:53:36]

Jun, could you try this new patch for me?

[Jun Mukai, 2013-06-21 21:12:43]

https://codereview.chromium.org/16909002/diff/4001/ui/views/controls/scrollba...
File ui/views/controls/scrollbar/overlay_scroll_bar.cc (right):

https://codereview.chromium.org/16909002/diff/4001/ui/views/controls/scrollba...
ui/views/controls/scrollbar/overlay_scroll_bar.cc:131: animation_.Hide();
On 2013/06/13 19:11:23, Jun Mukai wrote:
> The scrollbar doesn't hide when I fling the scroll view.  It seems that
> ET_SCROLL_FLING_START is triggered in that case.
> 
> Unfortunately FLING doesn't have END event, which means you'll probably have
to
> have a timer for closing. Or that's fine to just close immediately, since the
> scrollbar doesn't support velocity-move for fling right now.
> 
> Another approach is to catch the ET_TOUCH_PRESSED/ET_TOUCH_RELEASED
> OnTouchEvent, this will need to add some handler to ScrollView though.
> 
> Either is fine to me.

How did you address the issue I commented?  As far as I checked locally, the
scrollbar still doesn't hide for the fling behavior.

[dewittj, 2013-06-21 21:58:39]

I saw a comment in the code that there would be an ET_GESTURE_END event at the
end of a fling.  I guess I was wrong!

[Jun Mukai, 2013-06-21 22:52:18]

On 2013/06/21 21:58:39, dewittj wrote:
> I saw a comment in the code that there would be an ET_GESTURE_END event at the
> end of a fling.  I guess I was wrong!

probably better to ask rbyers or sadrul for the details.

[dewittj, 2013-06-21 23:02:33]

okay, I added a check for FLING_START

[Jun Mukai, 2013-06-24 21:51:23]

lgtm

[commit-bot: I haz the power, 2013-06-24 21:54:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dewittj@chromium.org/16909002/18001

[dewittj, 2013-06-24 21:55:26]

sadrul@, can you please take a look?

[sadrul, 2013-06-24 23:34:45]

LGTM

[commit-bot: I haz the power, 2013-06-24 23:37:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dewittj@chromium.org/16909002/18001

[commit-bot: I haz the power, 2013-06-25 04:00:19]

Change committed as 208383