Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1690883002: Revert of Disable smoothness.gpu_rasterization.tough_path_rendering_cases for yosemite. (Closed)

Created:
4 years, 10 months ago by petrcermak
Modified:
4 years, 10 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable smoothness.gpu_rasterization.tough_path_rendering_cases for yosemite. (patchset #1 id:1 of https://codereview.chromium.org/1632133002/ ) Reason for revert: The cause of the bug (crbug.com/581219) has most likely been fixed (https://codereview.chromium.org/1663673006). Original issue's description: > Disable smoothness.gpu_rasterization.tough_path_rendering_cases for yosemite. > > This has been consistently breaking in Mac 10.10. > > R=nednguyen,sullivan,eakuefner > CC=senorblanco > BUG=581219 > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect > > Committed: https://crrev.com/f0ed04968d9ca5844ce657946103cc2bb8c5dea0 > Cr-Commit-Position: refs/heads/master@{#371434} TBR=eakuefner@chromium.org,nednguyen@google.com,sullivan@chromium.org,robertocn@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=581219 Committed: https://crrev.com/637bb37dc1cc553cf8e90386703a7cc1b2c92949 Cr-Commit-Position: refs/heads/master@{#374898}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tools/perf/benchmarks/smoothness.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
petrcermak
Created Revert of Disable smoothness.gpu_rasterization.tough_path_rendering_cases for yosemite.
4 years, 10 months ago (2016-02-11 10:09:24 UTC) #1
petrcermak
PTAL. Thanks, Petr
4 years, 10 months ago (2016-02-11 10:09:55 UTC) #2
Stephen White
LGTM
4 years, 10 months ago (2016-02-11 12:12:17 UTC) #3
nednguyen
lgtm
4 years, 10 months ago (2016-02-11 14:07:32 UTC) #4
nednguyen
On 2016/02/11 14:07:32, nednguyen wrote: > lgtm If CQ_EXTRA_TRYBOTS fails with unrelated reasons, feel free ...
4 years, 10 months ago (2016-02-11 14:08:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1690883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1690883002/1
4 years, 10 months ago (2016-02-11 14:08:39 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 15:40:34 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:35:38 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/637bb37dc1cc553cf8e90386703a7cc1b2c92949
Cr-Commit-Position: refs/heads/master@{#374898}

Powered by Google App Engine
This is Rietveld 408576698